Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlook's SMTP server support #161

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

suntong
Copy link

@suntong suntong commented Nov 12, 2023

It's built on top of my previous two branches, and with the latest bump version here, things are a bit complicated now.

@s-gv
Copy link
Owner

s-gv commented Nov 13, 2023

Can you rebase just the relevant commit to the s-gv/orangeforum master? Thx!

@suntong
Copy link
Author

suntong commented Nov 13, 2023

That's however impossible via GH PR.

You have to do manually as per here:

https://github.com/suntong/orangeforum/compare/dev/email...suntong:orangeforum:dev/outlook?expand=1#diff-088d9f35d23a4347d221d71dd49b02b95001dff4abe637a40fe0bc04d502049c

This is the reason I didn't send in the PR previously, as I doubt that you'd take all the previous two branches it based on, which is a requirement to do PR in GH.

@suntong
Copy link
Author

suntong commented Nov 13, 2023

The easiest approach is,

  • either take the PR and revert the parts you don't want
  • or pick and choose interactively what you'd like to merge

@s-gv
Copy link
Owner

s-gv commented Nov 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants