Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlook's SMTP server support? #158

Open
suntong opened this issue Nov 9, 2023 · 10 comments
Open

Outlook's SMTP server support? #158

suntong opened this issue Nov 9, 2023 · 10 comments

Comments

@suntong
Copy link

suntong commented Nov 9, 2023

As explained in How to send email using Outlook's SMTP servers?, "Golang smtp does not support LOGIN", which is what Outlook's using.

Ok to switch the Golang smtp to other packages that support Outlook out of the box?
If so, I can send in PR.

@s-gv
Copy link
Owner

s-gv commented Nov 9, 2023 via email

@suntong
Copy link
Author

suntong commented Nov 9, 2023

I've went through about 7 different ways, including https://github.com/Shopify/gomail, but found the https://github.com/wneessen/go-mail to be the best of all implementations, and it happens to be following idiomatic Go style and best practice, and It's only dependency is the Go Standard Library.

@s-gv
Copy link
Owner

s-gv commented Nov 9, 2023 via email

@suntong
Copy link
Author

suntong commented Nov 9, 2023

Yes, being actively maintained is my de-facto number one priority.

  • Shopify/gomail last update on Jul 29, 2022
  • go-mail last update 3 weeks ago

@suntong
Copy link
Author

suntong commented Nov 10, 2023

Done, see

https://github.com/suntong/orangeforum/compare/dev/email...suntong:orangeforum:dev/outlook?expand=1#diff-088d9f35d23a4347d221d71dd49b02b95001dff4abe637a40fe0bc04d502049c

It's built on top of the previous two branches, so if you don't agree with the previous two changes, this would be the starting point to merge...

@suntong
Copy link
Author

suntong commented Nov 11, 2023

If it's my own, I'd

  • make the default sendMail to send html mail instead, so that the if condition for SMTPAuthLogin or SMTPAuthPlain can be embedded within itself, and
  • I'll write another wrapper on top of it to send text in markdown as html mail.

@s-gv
Copy link
Owner

s-gv commented Nov 11, 2023

Not a big fan default HTML mail. I'd rather stick to plain text.

@suntong
Copy link
Author

suntong commented Nov 11, 2023

Yeah, thought so, that's why I left it unchanged.

@s-gv
Copy link
Owner

s-gv commented Nov 12, 2023

Cool. Can you send a PR with that? It doesn't seem to be here. Thx!

@suntong
Copy link
Author

suntong commented Nov 12, 2023

OK, #161

As commented,

It's built on top of my previous two branches

So to send PR for this, I need to send all previous changes.

with the latest bump version here, things are a bit complicated now

I've manually resolved the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants