forked from SiliconLabs/UnifySDK
    
        
        - 
                Notifications
    You must be signed in to change notification settings 
- Fork 0
GH-20: Fix support for COMMAND_CLASS_METER V1,V2 & V3 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            rzr
  wants to merge
  3
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
GH-20/UIC-3082/phcoval/main
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Fixes bug where Attribute [0x3208] Value can not get resolved for legacy devices. Size of ZW_METER_GET_V3_FRAME is smaller than size of ZW_METER_GET_V5_FRAME. Legacy device supporting COMMAND_CLASS_METER_V3 and below will ignore received V5 frames, because frame size is larger than expected. Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
More to be tested Bug-SiliconLabs: UIC-3082 Bug-GitHub: #3 Origin: https://github.com/rzr/UnifySDK/tree/GH-14/UIC-3082/phcoval/main Forwarded: SiliconLabs#26 Signed-off-by: Philippe Coval <philippe.coval@silabs.com> (cherry picked from commit 92f99dc) Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…s of CC Bug-SiliconLabs: UIC-3082 Origin: https://github.com/rzr/UnifySDK/tree/GH-20/UIC-3082/phcoval/main Relate-to: nkljajic#1 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-20/develop Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
    
  rzr 
      added a commit
      that referenced
      this pull request
    
      Mar 18, 2025 
    
    
      
  
    
      
    
  
This change allow building UnifySDK on github.
Removing LFS objects is a good start to slim down UnifySDK repo
Observed issue:
    (...)
    #11 538.0 100% tests passed, 0 tests failed out of 69
    #11 538.0 Total Test time (real) = 287.70 sec
    #11 538.0 cmake --build build --target package
    (...)
    #11 538.2 [2/3] Run CPack packaging tool...
    #11 538.2 CPack: Create package using DEB
    #11 538.2 CPack: Install projects
    #11 538.2 CPack: - Install project: uic []
    #11 538.2 CPack: -   Install component: libunify-dev
    #11 538.7 CMake Error at /usr/local/opt/unifysdk/build/components/cmake_install.cmake:195 (file):
    #11 538.7   file INSTALL cannot copy file
Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
    
    
  rzr 
      added a commit
      that referenced
      this pull request
    
      Mar 24, 2025 
    
    
      
  
    
      
    
  
This change allow building UnifySDK on github.
Removing LFS objects is a good start to slim down UnifySDK repo
Observed issue:
    (...)
    #11 538.0 100% tests passed, 0 tests failed out of 69
    #11 538.0 Total Test time (real) = 287.70 sec
    #11 538.0 cmake --build build --target package
    (...)
    #11 538.2 [2/3] Run CPack packaging tool...
    #11 538.2 CPack: Create package using DEB
    #11 538.2 CPack: Install projects
    #11 538.2 CPack: - Install project: uic []
    #11 538.2 CPack: -   Install component: libunify-dev
    #11 538.7 CMake Error at /usr/local/opt/unifysdk/build/components/cmake_install.cmake:195 (file):
    #11 538.7   file INSTALL cannot copy file
Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
    
    
  rzr 
      added a commit
      that referenced
      this pull request
    
      Mar 24, 2025 
    
    
      
  
    
      
    
  
This change allow building UnifySDK on github.
Removing LFS objects is a good start to slim down UnifySDK repo
Observed issue:
    (...)
    #11 538.0 100% tests passed, 0 tests failed out of 69
    #11 538.0 Total Test time (real) = 287.70 sec
    #11 538.0 cmake --build build --target package
    (...)
    #11 538.2 [2/3] Run CPack packaging tool...
    #11 538.2 CPack: Create package using DEB
    #11 538.2 CPack: Install projects
    #11 538.2 CPack: - Install project: uic []
    #11 538.2 CPack: -   Install component: libunify-dev
    #11 538.7 CMake Error at /usr/local/opt/unifysdk/build/components/cmake_install.cmake:195 (file):
    #11 538.7   file INSTALL cannot copy file
Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
    
    
  rzr 
      added a commit
      that referenced
      this pull request
    
      Mar 28, 2025 
    
    
      
  
    
      
    
  
This change allow building UnifySDK on github.
Removing LFS objects is a good start to slim down UnifySDK repo
Observed issue:
    (...)
    #11 538.0 100% tests passed, 0 tests failed out of 69
    #11 538.0 Total Test time (real) = 287.70 sec
    #11 538.0 cmake --build build --target package
    (...)
    #11 538.2 [2/3] Run CPack packaging tool...
    #11 538.2 CPack: Create package using DEB
    #11 538.2 CPack: Install projects
    #11 538.2 CPack: - Install project: uic []
    #11 538.2 CPack: -   Install component: libunify-dev
    #11 538.7 CMake Error at /usr/local/opt/unifysdk/build/components/cmake_install.cmake:195 (file):
    #11 538.7   file INSTALL cannot copy file
Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
    
    
  rzr 
      added a commit
      that referenced
      this pull request
    
      Mar 28, 2025 
    
    
      
  
    
      
    
  
This change allow building UnifySDK on github.
Removing LFS objects is a good start to slim down UnifySDK repo
Observed issue:
    (...)
    #11 538.0 100% tests passed, 0 tests failed out of 69
    #11 538.0 Total Test time (real) = 287.70 sec
    #11 538.0 cmake --build build --target package
    (...)
    #11 538.2 [2/3] Run CPack packaging tool...
    #11 538.2 CPack: Create package using DEB
    #11 538.2 CPack: Install projects
    #11 538.2 CPack: - Install project: uic []
    #11 538.2 CPack: -   Install component: libunify-dev
    #11 538.7 CMake Error at /usr/local/opt/unifysdk/build/components/cmake_install.cmake:195 (file):
    #11 538.7   file INSTALL cannot copy file
Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Change
Checklist