-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add new feature: Interactive mode #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* feat: Obsidian同期機能と関連するCLIコマンドを追加 * feat: sync時に不足している日次ノートを生成する`--create`オプションを実装(デフォルトはデイリーノートが存在している日のログのみ同期する) * doc: Obsidian同期機能について追記 * refactor: 設定ファイルの読み書きをパス指定可能にリファクタリングし、設定、同期マネージャー、Obsidianターゲットの単体テストを追加 * refactor: ビジネスロジックをusecase層に移行 * chore: gitignoreに.DS_Storeを追加 * chore: makeコマンドにsetup(build&install)を追加 * refacor: メンテナンス向上のためリファクタリング * fix:行数が一番多いメモのパディングが全てのメモに適用されてしまう不具合の解消 * fix: hidden projectのイベントをデフォルトで同期しないようにした
* feat: インタラクティブモードを追加 * refactor: リファクタリングとコメント追加
* chore: 不要なファイルを削除 * fix: interactive modeの文字列の色を変更 * doc: READMEのデモGIF動画を差し替えた * doc: READMEにインタラクティブモードについての説明を追加
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2681128af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cmd/wip/sync.go
Outdated
| // Let's implement basics: --days and today (default) | ||
| fmt.Printf("Syncing specific date %s not fully implemented, falling back to --days\n", dateStr) | ||
| } else if days > 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honor --date by actually filtering sync range
The --date branch only logs a message and never sets any range in SummaryOptions, so GetSummary falls back to the default “today” window. That means wip sync --date 2024-01-01 will still sync today’s events and update today’s daily note, not the requested date, which is a user-visible behavior bug. Consider parsing dateStr and setting a start/end range (or bypassing SummaryUsecase) so the flag does what it advertises.
Useful? React with 👍 / 👎.
🚀 New Features