-
-
Notifications
You must be signed in to change notification settings - Fork 0
5-obs-sync #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5-obs-sync #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da6797a88f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Actually, we can just use `store` directly if Usecase is too restrictive. | ||
| // But Usecase adds context hydration (Git info etc). | ||
|
|
||
| // Let's implement basics: --days and today (default) | ||
| fmt.Printf("Syncing specific date %s not fully implemented, falling back to --days\n", dateStr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honor --date flag instead of defaulting to today
When --date is provided, this branch only prints a message and never adjusts the query options, so GetSummary still defaults to “today.” As a result, wip sync --date 2024-01-01 will sync today’s events instead of the requested date. Either parse dateStr and set a matching range (or query the store directly) or remove the flag until it’s implemented.
Useful? React with 👍 / 👎.
No description provided.