Added support for accepting jscodeshift ignore options (e.g. --ignore-config and --ignore-pattern)
#89
Conversation
src/options-support.js
Outdated
| function extractJSCodeShiftOptions(options, codeShiftOptions = jsCodeShiftOptions) { | ||
| let cliOptions = Object.assign({}, options); | ||
| let jsCodeShiftOptions = []; | ||
| codeShiftOptions.forEach(option => { | ||
| if (Object.prototype.hasOwnProperty.call(cliOptions, option)) { | ||
| let camelCaseOption = option.replace(/-([a-z])/g, (_, up) => up.toUpperCase()); | ||
| jsCodeShiftOptions.push(`--${option}`, options[option]); | ||
| delete cliOptions[option]; | ||
| delete cliOptions[camelCaseOption]; | ||
| } | ||
| }); | ||
| return { cliOptions, jsCodeShiftOptions }; | ||
| } |
There was a problem hiding this comment.
I think I'd prefer to do this all in parseTransformArgs, and ahve that essentially return { paths, options, transformerOptions } or something like that.
What do you think?
There was a problem hiding this comment.
Hi, this is my first open-source contribution that's why I was little hesitant towards altering the existing function and breaking the existing flow. Anyways, I have incorporated the changes in the parseTransformArgs itself.
Kindly have a look and let me know if this is okay.
|
I just landed a fairly big refactor from @simonihmig, would you mind rebasing on top of that work? I think it shouldn't dramatically affect what you have done here, but I just want to make sure CI is happy with the two changes together before landing. Also, we need to probably figure out how to do the parsing a bit better in general (instead of using |
|
I have rebased with the master and things look good. Will try to create a new PR to address the parsing. |
rwjblue
changed the title
jscodeshift ignore options (e.g. --ignore-config and --ignore-pattern)
#88