Update imports codemod #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajasegar-c
suggested changes
Jun 27, 2020
| ], | ||
| "scripts": { | ||
| "test": "qunit tests/*-test.js", | ||
| "test": "qunit tests/*-test.js tests/**/*-test.js", |
There was a problem hiding this comment.
Suggested change
| "test": "qunit tests/*-test.js tests/**/*-test.js", | |
| "test": "qunit tests/**/*-test.js", |
This is enough to catch all
There was a problem hiding this comment.
I tried but it didn't work. It was picking the test files present inside the subdirectories only and not the ones that are directly available under the tests directory
src/commands/adapter.js
Outdated
|
|
||
| createAppExport({ | ||
| fileName: adapterName, | ||
| sourceFile: sourceadapter, |
src/commands/constant.js
Outdated
|
|
||
| createAppExport({ | ||
| fileName: constantName, | ||
| sourceFile: sourceconstant, |
src/commands/helper.js
Outdated
| // Create helper assets to app folder in addon | ||
| createAppExport({ | ||
| fileName: helperName, | ||
| sourceFile: sourcehelper, |
src/commands/mixin.js
Outdated
|
|
||
| createAppExport({ | ||
| fileName: mixinName, | ||
| sourceFile: sourcemixin, |
src/commands/service.js
Outdated
|
|
||
| createAppExport({ | ||
| fileName: serviceName, | ||
| sourceFile: sourceservice, |
src/commands/util.js
Outdated
|
|
||
| createAppExport({ | ||
| fileName: utilName, | ||
| sourceFile: sourceutil, |
src/commands/validator.js
Outdated
| // Create validator assets to app folder in addon | ||
| createAppExport({ | ||
| fileName: validatorName, | ||
| sourceFile: sourcevalidator, |
src/utils/create-app-export.js
Outdated
| // Commenting it out as the ignore pattern and config options are not supported by codemod-cli. | ||
| // log(`\nUpdating the import paths matching ${oldImportPath} to ${exportPath}`); | ||
| let updateImports = false; | ||
| if (updateImports) { |
There was a problem hiding this comment.
What are we doing here? the if condition will never be true here
There was a problem hiding this comment.
Updated the code
|
|
||
| ## Input / Output | ||
|
|
||
| <!--FIXTURES_TOC_START--> |
There was a problem hiding this comment.
I think you should run
codemod-cli update-docs
to update the examples here
rajasegar
approved these changes
Jul 7, 2020
|
@vinodh-kumar-1711 Can you please check the failing tests? |
|
That test will pass after this codemod-cli PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.