fix: cross-platform build, manifest verification, sensing server warnings, and off-axis robustness - #1629
Open
RMNO21 wants to merge 1 commit into
Open
Conversation
…ings, and off-axis robustness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR resolves cross-platform compilation and manifest verification issues, eliminates compiler warnings in the sensing server, and enhances mathematical robustness in off-axis perspective projection:
Harness & Provenance Manifest Integrity:
harness/homecore/** text=auto eol=lfto.gitattributesto ensure byte-for-byte LF provenance preservation across operating systems.harness/homecore/.harness/manifest.sha256to passnpm run manifest:verify.Windows Desktop Crate-Type Linking:
crate-typeinv2/crates/wifi-densepose-desktop/Cargo.tomlfrom["staticlib", "cdylib", "rlib"]to["lib"]to prevent GCC/MinGW linker export ordinal overflow (>65535symbol limit on PE/COFF).Compiler Warnings & Struct Field Initialization:
multistatic_cfgbeforeAppStateInnerinstantiation inv2/crates/wifi-densepose-sensing-server/src/main.rs, removing theunused_assignmentscompiler warning.mutinmatter/bridge.rsand unused imports inmatter/commissioning.rs.Orthonormal Basis Robustness in Off-Axis Projection:
vu = vn.cross(vr)inruview-offaxis::Screen::newto guarantee that{vr, vu, vn}forms an exact right-handed orthonormal basis (zero shear / pure rotation matrix) even when physical screen corner measurements have slight non-perpendicularities.screen_basis_is_strictly_orthonormal_under_skewed_cornersinprojection.rs.Verification
npm test && npm run test:security && npm run brain:verify && npm run manifest:verify && npm run flywheel:planinharness/ruview: PASS (81 tests, 13 security tests, 0 findings)npm test && npm run test:security && npm run brain:verify -- --repo ../.. && npm run manifest:verifyinharness/homecore: PASS (27 tests, 23 security tests, 0 findings)cargo test -p ruview-offaxis -p wifi-densepose-sensing-server --no-default-featuresinv2: PASS (287 tests passed, 0 failed, 0 warnings)python archive/v1/data/proof/verify.py: PASS (VERDICT: PASS, bit-exact hash match)