-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add support for running wasm-snip #163
Conversation
hey @csmoe ! thanks so much for this- it's looking really good. so we have a release coming up on wednesday and i think, unfortunately we're not gonna be able to sneak this in because there's some outstanding questions re #160 about configuration. i'm gonna make this as blocked for the moment, but the second after we get the most recent release out, i'll turn my attention back to this and see if we can't land it sooner than later and add the configuration option later so that we don't have to run you through too many rebases 😅 thanks again for submitting and sorry for having to ask you to wait, but hopefully it shouldn't be too long ✨ 💁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Real solid PR! Like Ashley said we'll need to hold off on this but this is great :D
2e5a2c0
to
a57d0a0
Compare
@csmoe are you still planning to work on this? If you've run out of bandwidth, I'd be happy to help. I'd like to get this and wasm-opt integration in. |
@nicksrandall really thanks. just do whatever you wanna. |
this PR is quite outdated- i'm sorry about this :( would you mind if we closed? we still want this feature but i imagine it will be easier to start a new PR to accomplish this. let me know what you think! |
yep It's better to restart |
Closes #158
Make sure these boxes are checked! 📦✅
rustfmt
installed and have yourcloned directory set to nightly
$ rustup override set nightly $ rustup component add rustfmt-preview --toolchain nightly
rustfmt
on the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨