Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running wasm-snip #158

Open
fitzgen opened this issue Jun 7, 2018 · 2 comments
Open

Add support for running wasm-snip #158

fitzgen opened this issue Jun 7, 2018 · 2 comments
Labels
feature request needs design to-do stuff that needs to happen, so plz do it k thx

Comments

@fitzgen
Copy link
Member

fitzgen commented Jun 7, 2018

See also wasm-tool/rust-plugin#1 and #153

Basically there are four main options:

  • Should we snip the std::panicking code? yes/no

  • Should we snip the std::fmt code? yes/no

  • Here are some specific functions to snip. (list of zero or more strings)

  • Here are some regex patterns of functions to snip. (list of zero or more strings)

@ashleygwilliams ashleygwilliams added help wanted Extra attention is needed question Further information is requested to-do stuff that needs to happen, so plz do it k thx labels Jun 7, 2018
@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue and removed help wanted Extra attention is needed labels Jun 11, 2018
@ashleygwilliams ashleygwilliams added this to the 0.5.0 milestone Jun 11, 2018
@ashleygwilliams ashleygwilliams modified the milestones: 0.5.0, 0.6.0 Jul 26, 2018
@ashleygwilliams ashleygwilliams removed this from the 0.6.0 milestone Dec 27, 2018
@ashleygwilliams ashleygwilliams added feature request needs design and removed PR attached there's a PR open for this issue question Further information is requested to-do stuff that needs to happen, so plz do it k thx labels Jul 16, 2019
@ashleygwilliams
Copy link
Member

following up on this feature request- do we still want to do this? how do we want to prioritize this?

@fitzgen
Copy link
Member Author

fitzgen commented Jul 16, 2019

do we still want to do this?

Yes, I believe so.

how do we want to prioritize this?

Not super high, in my opinion. I think the existing RFCs, wasm-opt support, and serve/watch are probably all higher priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request needs design to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants