Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homepage: a lot of internal links are broken #325

Closed
matthiaskrgr opened this issue Sep 21, 2018 · 4 comments · Fixed by #328
Closed

homepage: a lot of internal links are broken #325

matthiaskrgr opened this issue Sep 21, 2018 · 4 comments · Fixed by #328
Labels
bug Something isn't working PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx user report
Milestone

Comments

@matthiaskrgr
Copy link

matthiaskrgr commented Sep 21, 2018

I landed on https://github.com/rustwasm/wasm-pack, clicked on the link in the repo description which is
https://rustwasm.github.io/wasm-pack/

Inside this website, it looks like most of the links to other parts of the website throw 404.
For example if I click rust of previously linked page, the url points to
"https://rustwasm.github.io/prerequisites/rust.html" which 404s, but the side-bar has the correct url which is
"https://rustwasm.github.io/wasm-pack/prerequisites/rust.html".

Looks like the internal links are missing wasm-pack/ after https://rustwasm.github.io/ ?

@ashleygwilliams ashleygwilliams added bug Something isn't working to-do stuff that needs to happen, so plz do it k thx user report labels Sep 21, 2018
@ashleygwilliams
Copy link
Member

yes! thanks for reporting. would happily take a PR for this :)

@ashleygwilliams ashleygwilliams added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 21, 2018
@mstallmo
Copy link
Member

mstallmo commented Sep 21, 2018

I'm currently working on a quick PR to fix this up but I'm new markdown books, is there anyway I can make a build of this locally to see and test my changes?

@ashleygwilliams
Copy link
Member

yup! if you cargo install mdbook you can run mdbook serve in the /docs directory :) there's more info here as well: https://github.com/rust-lang-nursery/mdBook

@mstallmo
Copy link
Member

Awesome, thanks!

@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue and removed good first issue Good for newcomers help wanted Extra attention is needed labels Sep 21, 2018
@ashleygwilliams ashleygwilliams added this to the 0.5.0 milestone Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx user report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants