Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in book by replacing absolute paths with relative paths #328

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

mstallmo
Copy link
Member

fixes #325

Switched the links from using absolute paths to relative paths. Should now work locally served with mdBooks and when served on pages.

Make sure these boxes are checked! πŸ“¦βœ…

  • You have the latest version of rustfmt installed and have your
    cloned directory set to nightly
$ rustup override set nightly
$ rustup component add rustfmt-preview --toolchain nightly
  • You ran rustfmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ πŸ˜„ Thanks so much for contributing to wasm-pack! πŸ˜„ ✨✨

@ashleygwilliams ashleygwilliams added this to the 0.5.0 milestone Sep 21, 2018
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for this!

@ashleygwilliams ashleygwilliams merged commit 4a1a4be into rustwasm:master Sep 21, 2018
@mstallmo mstallmo deleted the fix-links branch September 21, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

homepage: a lot of internal links are broken
2 participants