Skip to content

Commit

Permalink
Don't install wasm-opt in CI (#3366)
Browse files Browse the repository at this point in the history
* Don't install binaryen in CI

This is a workaround for rustwasm/wasm-pack#1247, which causes `wasm-pack` to fail to run if a local version of `wasm-opt` is installed. That in turn caused the `build_examples` CI job to break.

This PR fixes that by not having it download binaryen, instead letting `wasm-pack` install it itself, which still works.

* Put back the binaryen-installing step, but only install wasm2js instead of the whole thing.

I also updated to binaryen 112 while I was at it.
  • Loading branch information
Liamolucko committed Mar 24, 2023
1 parent bea9bdb commit 2a28cfb
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,9 @@ jobs:
- run: rustup target add wasm32-unknown-unknown
- run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh -s -- -f
- run: |
curl -L https://github.com/WebAssembly/binaryen/releases/download/version_109/binaryen-version_109-x86_64-linux.tar.gz -sSf > binaryen-version_109-x86_64-linux.tar.gz
tar -xz -f binaryen-version_109-x86_64-linux.tar.gz
echo "$PWD/binaryen-version_109/bin" >> $GITHUB_PATH
curl -L https://github.com/WebAssembly/binaryen/releases/download/version_112/binaryen-version_112-x86_64-linux.tar.gz -sSf > binaryen-version_112-x86_64-linux.tar.gz
tar -xz -f binaryen-version_112-x86_64-linux.tar.gz binaryen-version_112/bin/wasm2js
echo "$PWD/binaryen-version_112/bin" >> $GITHUB_PATH
- run: |
cargo build -p wasm-bindgen-cli
ln -snf `pwd`/target/debug/wasm-bindgen $(dirname `which cargo`)/wasm-bindgen
Expand Down

0 comments on commit 2a28cfb

Please sign in to comment.