v0.11.0 Locally installed wasm-opt not found

[nakamurarts]

🐛 Bug description

When I run the command wasm-pack build --target web, I get an error that says wasm-opt is not found, even though wasm-opt exists in PATH.

The situation is similar to #1062, but the version (and possibly the cause) is different, so I have started a new issue.

See also: #1062 (comment) #1062 (comment)

🤔 Expected Behavior

The installed wasm-opt will be used

👟 Steps to reproduce

1. run cargo new --lib hello-wasm and implement a simple project hello-wasm following MDN tutorial

2. run wasm-pack build --target web and get the following error

> wasm-pack build --target web
[INFO]: Checking for the Wasm target...
[INFO]: Compiling to Wasm...
  Finished release [optimized] target(s) in 0.03s
[WARN]: :-) origin crate has no README
[INFO]: Installing wasm-bindgen...
[INFO]: found wasm-opt at "C:\\Users\\user\\scoop\\shims\\wasm-opt.exe"
Error: C:\Users\user\scoop\shims\bin/wasm-opt.exe binary does not exist
To disable `wasm-opt`, add `wasm-opt = false` to your package metadata in your `Cargo.toml`.
Caused by: C:\Users\user\scoop\shims\bin/wasm-opt.exe binary does not exist
To disable `wasm-opt`, add `wasm-opt = false` to your package metadata in your `Cargo.toml`.

🌍 Your environment

on Windows 10:

> rustc --version
rustc 1.68.0 (2c8cc3432 2023-03-06)

> wasm-pack --version
wasm-pack 0.11.0

> wasm-opt --version
wasm-opt version 112 (version_112)

on Fedora 37:

$ rustc --version
rustc 1.67.1 (d5a82bbd2 2023-02-07)

$ wasm-pack --version
wasm-pack 0.11.0

$ wasm-opt --version
wasm-opt version 110

[nakamurarts]

ad hoc fix (still passes all cargo tests in my environment):

(src/wasm_opt.rs)

//! Support for downloading and executing `wasm-opt`

use crate::child;
use crate::install;
use crate::PBAR;
use anyhow::Result;
use binary_install::Cache;
use std::path::Path;
use std::process::Command;

/// Execute `wasm-opt` over wasm binaries found in `out_dir`, downloading if
/// necessary into `cache`. Passes `args` to each invocation of `wasm-opt`.
pub fn run(cache: &Cache, out_dir: &Path, args: &[String], install_permitted: bool) -> Result<()> {
    let wasm_opt_path = match find_wasm_opt(cache, install_permitted)? {
        Status::Found(path) => path,
        Status::Install(status) => match status {
            install::Status::Found(dl) => dl.binary("bin/wasm-opt")?,
            install::Status::CannotInstall => {
                PBAR.info("Skipping wasm-opt as no downloading was requested");
                return Ok(());
            }
            install::Status::PlatformNotSupported => {
                PBAR.info("Skipping wasm-opt because it is not supported on this platform");
                return Ok(());
            }
        },
    };

    PBAR.info("Optimizing wasm binaries with `wasm-opt`...");

    for file in out_dir.read_dir()? {
        let file = file?;
        let path = file.path();
        if path.extension().and_then(|s| s.to_str()) != Some("wasm") {
            continue;
        }

        let tmp = path.with_extension("wasm-opt.wasm");
        let mut cmd = Command::new(&wasm_opt_path);
        cmd.arg(&path).arg("-o").arg(&tmp).args(args);
        child::run(cmd, "wasm-opt")?;
        std::fs::rename(&tmp, &path)?;
    }

    Ok(())
}

/// Possible outcomes of attempting to find/install `wasm-opt`
pub enum Status {
    /// We found `wasm-opt` at the specified path (in PATH)
    Found(std::path::PathBuf),
    /// Installation results
    Install(install::Status),
}

/// Attempts to find `wasm-opt` in `PATH` locally, or failing that downloads a
/// precompiled binary.
///
/// Returns `Some` if a binary was found or it was successfully downloaded.
/// Returns `None` if a binary wasn't found in `PATH` and this platform doesn't
/// have precompiled binaries. Returns an error if we failed to download the
/// binary.
pub fn find_wasm_opt(cache: &Cache, install_permitted: bool) -> Result<Status> {
    // First attempt to look up in PATH. If found assume it works.
    if let Ok(path) = which::which("wasm-opt") {
        PBAR.info(&format!("found wasm-opt at {:?}", path));
        return Ok(Status::Found(path));
    }

    Ok(Status::Install(install::download_prebuilt(
        &install::Tool::WasmOpt,
        cache,
        "latest",
        install_permitted,
    )?))
}

[tmpfs]

Same issue here on MacOS with 0.11:

[INFO]: found wasm-opt at "/opt/homebrew/bin/wasm-opt"
Error: /opt/homebrew/bin/bin/wasm-opt binary does not exist

Looks like it is adding an extra bin to the path for some reason.

Going to downgrade back to 0.10.3 for now.

[mogtofu33]

Temporary fix is to symlink ~/bin/wasm-opt to ~/bin/bin/wasm-opt

[dylanh724]

This issue still persists on Windows to this day, @drager

[drager]

This issue still persists on Windows to this day, @drager

Still an issue in 0.13.0? If so, please open a new issue.