Skip to content

Add support for multiboot information at an offset. #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2019
Merged

Add support for multiboot information at an offset. #54

merged 1 commit into from
Feb 25, 2019

Conversation

ahmedcharles
Copy link
Contributor

No description provided.

xacrimon
xacrimon previously approved these changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@xacrimon xacrimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge

@xacrimon
Copy link
Contributor

Can't merge. Please sync the base branch to yours.

@ahmedcharles
Copy link
Contributor Author

Should be the same as before with some adjustments to work with the other PR.

xacrimon
xacrimon approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@xacrimon xacrimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gr8

@xacrimon xacrimon merged commit d3bf8d3 into rust-osdev:master Feb 25, 2019
@xacrimon
Copy link
Contributor

Merged

@ahmedcharles ahmedcharles deleted the offset branch February 26, 2019 02:21
@ahmedcharles
Copy link
Contributor Author

Thanks.

@phip1611
Copy link
Member

phip1611 commented Jun 20, 2023 •
edited
Loading

For API simplifications and streamlining, I'm planning to deprecate the "with offset" API. I could not find a valid reason for this "more complicated" API, as it is a no-brainer to perform a ptr.add(offset) as a developer and just use the regular load function.

#142

I'm not going to merge this today or tomorrow, so that

  • people have chances to explain to me if I miss something and this API is indeed very important
  • I have more time to see if I missed something

UPDATE
I got additional feedback from at least one person that is also in favor of dropping the offset API. I don't want to disrespect anyone's work, but I think this API did not pass the test of time. It can be simplified. Feel free to correct me if I'm wrong :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xacrimon xacrimon xacrimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedcharles @xacrimon @phip1611