multiboot2: load: remove odd offset thingy #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @YtvwlD What do you think about this API change? I'd like to get rid of the weird offset thingy. I do not see a reason why it is necessary at all. Please change my mind, if I miss something. |
phip1611
force-pushed
the
dev
branch
4 times, most recently
from
e017a18 to
37ea973
Compare
phip1611
changed the title
|
I did not understand why it was there, either. And the PR that added this came with no explanation either, right? Perhaps this is for segmentation or something like that? |
yes
Hm, but the offset was added to the pointer in any case.. hm.. strange. I wait one more day and then merge it. |
|
So, you are also in favor of this API change/improvement/simplification, @YtvwlD , right? |
phip1611
force-pushed
the
dev
branch
11 times, most recently
from
202b80a to
1e389fa
Compare
|
I don't have an opinion on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the weird
load_with_offsetthingy which can also be done via an adjusted pointer. -> less complexityFurthermore, the Multiboot2 information structure now captures the lifetime of the context where it is created. Last but not least, due to the pointer provenance developments in Rust, it is much better to consume a pointer instead of an exposed address.