Skip to content

route: Implement support for the ONLINK flag #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025

Conversation

rwestphal
Copy link
Contributor

This is an alternative to #41, which seems to be stale. In this PR, I didn't expose all the route flags since most of them don't really make sense when creating a route. I think it's better to add small builder methods for the flags that do make sense.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Copy link
Member

@cathay4t cathay4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR is better as it hides the internal implementation. For anyone want arbitrary flags modification, they can modify the RouteMessage generated by RouteMessageBuilder::build().

@cathay4t cathay4t enabled auto-merge (rebase) April 20, 2025 01:39
@cathay4t cathay4t merged commit 30aa30f into rust-netlink:main Apr 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants