route: allow IPv6 gateway in IPv4 route #90
Conversation
|
I don't link breaking API for this corner case. Please add If possible, please also provide example ip command showing it actual working. |
|
@hack3ric Hi! I'm also interested in this. Just wondering if you're planning to update this PR? If not, I might go ahead and open one myself. I'll also need the conditional |
|
Sure, I'll update the PR after the weekend. |
hack3ric
force-pushed
the
extended-next-hop
branch
from
355ccce to
a09ba72
Compare
hack3ric
force-pushed
the
extended-next-hop
branch
from
a09ba72 to
c86090f
Compare
|
@rwestphal Done |
src/route/builder.rs
Outdated
| @@ -168,6 +168,13 @@ impl RouteMessageBuilder<Ipv4Addr> { | |||
| .push(RouteAttribute::Gateway(RouteAddress::Inet(addr))); | |||
| self | |||
| } | |||
|
|
|||
| pub fn gateway6(mut self, addr: Ipv6Addr) -> Self { | |||
There was a problem hiding this comment.
Since we already patched gateway() to support assigning ipv6 gateway to a ipv4 route, we do not need this function anymore.
For precise control, maybe change this function to pub fn via(mut self, via: RouteVia) -> Self.
There was a problem hiding this comment.
Yes, anyone who wants an IPv4 route with an IPv6 nexthop should probably be using RouteMessageBuilder<IpAddr>. I think this method could be dropped.
There was a problem hiding this comment.
Sorry for the late reply. Changed the function name to via, as IMO it would be less consistent in regards of functionality between the Ipv4Addr and IpAddr builders, if removing this completely.
|
@hack3ric ping |
hack3ric
force-pushed
the
extended-next-hop
branch
from
c86090f to
afb6018
Compare
Linux supports it by using RTA_VIA instead of RTA_GATEWAY. Since it essentially acts as gateway, we extend the current API to allow it.
hack3ric
force-pushed
the
extended-next-hop
branch
from
afb6018 to
ea13ce2
Compare
Linux supports it by using RTA_VIA instead of RTA_GATEWAY. Since it essentially acts as gateway, we extend the current API to allow it.