Skip to content

Governance internationalization #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 23, 2019
Merged

Conversation

Manishearth
Copy link
Member

Based on #794

Needs rust-lang/team#70

This is a tad more involved since the team data comes from https://github.com/rust-lang/team

@Manishearth Manishearth marked this pull request as ready for review May 23, 2019 05:59
@Manishearth
Copy link
Member Author

Ready for review. It's fine to just review this PR all at once and land, but if you want to do it piecewise it may make sense to land #794 first

@Manishearth
Copy link
Member Author

I think with this PR the rest of the i18n is completely mechanical -- going through the templates, adding localization strings, and moving on. Once this lands we can also start asking folks to translate the ftl files (ideally pontoon is set up, but it's not necessary)

@Manishearth Manishearth added the A-i18n Internationalising the website. label May 23, 2019
Copy link
Contributor

@skade skade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@skade skade merged commit 77a68ff into rust-lang:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-i18n Internationalising the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants