Skip to content

Allow dumping website data as FTL files #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2019

Conversation

Manishearth
Copy link
Member

I'm working on internationalizing the website (rust-lang/www.rust-lang.org#792), and for that eventually the website text data will have to come from an FTL file.

My implementation has fallback to the website data stored in this repo, but I need this tool so that I can generate an English FTL file that others can translate.

Since the team name is being used in Handlebars templates, I'm also forcing the internal identifier used for the team to be alphanumeric (plus dashes)

r? @pietroalbini

@pietroalbini pietroalbini self-assigned this May 23, 2019
@pietroalbini
Copy link
Member

The PR looks good, but what's the update procedure when a new team is added or when a team's description is updated? The goal of this repo would be that any team-related change could be done by sending a PR here, does this add other steps?

The new command should also be documented in the readme.

@Manishearth
Copy link
Member Author

The PR looks good, but what's the update procedure when a new team is added or when a team's description is updated? The goal of this repo would be that any team-related change could be done by sending a PR here, does this add other steps?

So if you add a team here it will Just Work on the website, but translators will not be able to translate it until you rerun dump-website.

@Manishearth
Copy link
Member Author

Basically, the English site uses the team data (and any language without translations for team data). However the translation tools only understand FTL files, so we create this file for the benefit of translators.

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks good then. Add some bits of doc in the readme and feel free to merge.

@Manishearth
Copy link
Member Author

Done

@pietroalbini pietroalbini merged commit 4c9af81 into rust-lang:master May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants