Skip to content

add Solaris support #4380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -900,13 +900,15 @@ jobs:
- i686-unknown-linux-gnu # skip-pr skip-master
- arm-unknown-linux-gnueabi # skip-pr skip-master
- arm-unknown-linux-gnueabihf # skip-pr skip-master
- x86_64-pc-solaris # skip-pr skip-master
- x86_64-unknown-freebsd # skip-pr skip-master
- x86_64-unknown-netbsd # skip-pr skip-master
- x86_64-unknown-illumos # skip-pr skip-master
- powerpc-unknown-linux-gnu # skip-pr skip-master
- powerpc64le-unknown-linux-gnu # skip-pr skip-master
- powerpc64le-unknown-linux-musl # skip-pr skip-master
- s390x-unknown-linux-gnu # skip-pr skip-master
- sparcv9-sun-solaris # skip-pr skip-master
- arm-linux-androideabi # skip-pr skip-master
- armv7-linux-androideabi # skip-pr skip-master
- x86_64-linux-android # skip-pr skip-master
Expand Down
2 changes: 2 additions & 0 deletions ci/actions-templates/linux-builds-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,15 @@ jobs: # skip-master skip-pr skip-stable
- i686-unknown-linux-gnu # skip-pr skip-master
- arm-unknown-linux-gnueabi # skip-pr skip-master
- arm-unknown-linux-gnueabihf # skip-pr skip-master
- x86_64-pc-solaris # skip-pr skip-master
- x86_64-unknown-freebsd # skip-pr skip-master
- x86_64-unknown-netbsd # skip-pr skip-master
- x86_64-unknown-illumos # skip-pr skip-master
- powerpc-unknown-linux-gnu # skip-pr skip-master
- powerpc64le-unknown-linux-gnu # skip-pr skip-master
- powerpc64le-unknown-linux-musl # skip-pr skip-master
- s390x-unknown-linux-gnu # skip-pr skip-master
- sparcv9-sun-solaris # skip-pr skip-master
- arm-linux-androideabi # skip-pr skip-master
- armv7-linux-androideabi # skip-pr skip-master
- x86_64-linux-android # skip-pr skip-master
Expand Down
4 changes: 4 additions & 0 deletions ci/cloudfront-invalidation.txt
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,14 @@ rustup/dist/powerpc64le-unknown-linux-musl/rustup-init
rustup/dist/powerpc64le-unknown-linux-musl/rustup-init.sha256
rustup/dist/s390x-unknown-linux-gnu/rustup-init
rustup/dist/s390x-unknown-linux-gnu/rustup-init.sha256
rustup/dist/sparcv9-sun-solaris/rustup-init.exe
rustup/dist/sparcv9-sun-solaris/rustup-init.exe.sha256
rustup/dist/x86_64-apple-darwin/rustup-init
rustup/dist/x86_64-apple-darwin/rustup-init.sha256
rustup/dist/x86_64-linux-android/rustup-init
rustup/dist/x86_64-linux-android/rustup-init.sha256
rustup/dist/x86_64-pc-solaris/rustup-init.exe
rustup/dist/x86_64-pc-solaris/rustup-init.exe.sha256
rustup/dist/x86_64-pc-windows-gnu/rustup-init.exe
rustup/dist/x86_64-pc-windows-gnu/rustup-init.exe.sha256
rustup/dist/x86_64-pc-windows-msvc/rustup-init.exe
Expand Down
12 changes: 12 additions & 0 deletions ci/docker/sparcv9-sun-solaris/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
FROM rust-sparcv9-sun-solaris

# Building `aws-lc-rs` for Solaris on Linux depends on `gcc-multilib`, `libclang` and `bindgen`.
# See: https://aws.github.io/aws-lc-rs/requirements/linux
RUN apt-get update && apt-get install -qy gcc-multilib libclang-dev

ENV \
AR_sparcv9_sun_solaris=sparcv9-solaris-ar \
RANLIB_sparcv9_sun_solaris=sparcv9-solaris-ranlib \
CC_sparcv9_sun_solaris=sparcv9-solaris-gcc \
CXX_sparcv9_sun_solaris=sparcv9-solaris-g++ \
CARGO_TARGET_SPARCV9_SUN_SOLARIS_LINKER=sparcv9-solaris-gcc
12 changes: 12 additions & 0 deletions ci/docker/x86_64-pc-solaris/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
FROM rust-x86_64-pc-solaris

# Building `aws-lc-rs` for Solaris on Linux depends on `gcc-multilib`, `libclang` and `bindgen`.
# See: https://aws.github.io/aws-lc-rs/requirements/linux
RUN apt-get update && apt-get install -qy gcc-multilib libclang-dev

ENV \
AR_x86_64_pc_solaris=x86_64-solaris-ar \
RANLIB_x86_64_pc_solaris=x86_64-solaris-ranlib \
CC_x86_64_pc_solaris=x86_64-solaris-gcc \
CXX_x86_64_pc_solaris=x86_64-solaris-g++ \
CARGO_TARGET_X86_64_PC_SOLARIS_LINKER=x86_64-solaris-gcc
2 changes: 2 additions & 0 deletions ci/fetch-rust-docker.bash
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ case "$TARGET" in
powerpc64le-unknown-linux-gnu) image=dist-powerpc64le-linux-gnu ;;
powerpc64le-unknown-linux-musl) image=dist-powerpc64le-linux-musl ;;
s390x-unknown-linux-gnu) image=dist-s390x-linux ;;
sparcv9-sun-solaris) image=dist-sparcv9-solaris ;;
x86_64-pc-solaris) image=dist-x86_64-solaris ;;
x86_64-unknown-freebsd) image=dist-x86_64-freebsd ;;
x86_64-unknown-illumos) image=dist-x86_64-illumos ;;
x86_64-unknown-linux-gnu) image=dist-x86_64-linux ;;
Expand Down
1 change: 1 addition & 0 deletions ci/run.bash
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ case "$TARGET" in
loongarch* ) ;;
*netbsd* ) ;;
*illumos* ) ;;
*solaris* ) ;;
# default case, build with rustls enabled
* ) FEATURES+=('--features' 'reqwest-rustls-tls') ;;
esac
Expand Down
4 changes: 4 additions & 0 deletions doc/user-guide/src/installation/other.md
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,14 @@ You can manually download `rustup-init` for a given target from
- [sha256 file](https://static.rust-lang.org/rustup/dist/powerpc64le-unknown-linux-musl/rustup-init.sha256)
- [s390x-unknown-linux-gnu](https://static.rust-lang.org/rustup/dist/s390x-unknown-linux-gnu/rustup-init)
- [sha256 file](https://static.rust-lang.org/rustup/dist/s390x-unknown-linux-gnu/rustup-init.sha256)
- [sparcv9-sun-solaris](https://static.rust-lang.org/rustup/dist/sparcv9-sun-solaris/rustup-init)
- [sha256 file](https://static.rust-lang.org/rustup/dist/sparcv9-sun-solaris/rustup-init.sha256)
- [x86_64-apple-darwin](https://static.rust-lang.org/rustup/dist/x86_64-apple-darwin/rustup-init)
- [sha256 file](https://static.rust-lang.org/rustup/dist/x86_64-apple-darwin/rustup-init.sha256)
- [x86_64-linux-android](https://static.rust-lang.org/rustup/dist/x86_64-linux-android/rustup-init)
- [sha256 file](https://static.rust-lang.org/rustup/dist/x86_64-linux-android/rustup-init.sha256)
- [x86_64-pc-solaris](https://static.rust-lang.org/rustup/dist/x86_64-pc-solaris/rustup-init)
- [sha256 file](https://static.rust-lang.org/rustup/dist/x86_64-pc-solaris/rustup-init.sha256)
- [x86_64-pc-windows-gnu](https://static.rust-lang.org/rustup/dist/x86_64-pc-windows-gnu/rustup-init.exe)[^msys2]
- [sha256 file](https://static.rust-lang.org/rustup/dist/x86_64-pc-windows-gnu/rustup-init.exe.sha256)
- [x86_64-pc-windows-msvc](https://static.rust-lang.org/rustup/dist/x86_64-pc-windows-msvc/rustup-init.exe)[^msvc]
Expand Down
11 changes: 11 additions & 0 deletions rustup-init.sh
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,14 @@ get_architecture() {
_ostype=unknown-illumos
;;

SunOS)
if [ "$_cputype" = sparcv9 ]; then
_ostype=sun-solaris
else
_ostype=pc-solaris
fi
;;

MINGW* | MSYS* | CYGWIN* | Windows_NT)
_ostype=pc-windows-gnu
;;
Expand Down Expand Up @@ -491,6 +499,9 @@ get_architecture() {
s390x)
_cputype=s390x
;;
sparcv9)
_cputype=sparcv9
;;
riscv64)
_cputype=riscv64gc
;;
Expand Down
6 changes: 5 additions & 1 deletion src/dist/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ impl TargetTriple {
let mut sys_info;
let (sysname, machine) = unsafe {
sys_info = mem::zeroed();
if libc::uname(&mut sys_info) != 0 {
if libc::uname(&mut sys_info) == -1 {
return None;
}

Expand Down Expand Up @@ -532,7 +532,11 @@ impl TargetTriple {
(b"NetBSD", b"x86_64") => Some("x86_64-unknown-netbsd"),
(b"NetBSD", b"i686") => Some("i686-unknown-netbsd"),
(b"DragonFly", b"x86_64") => Some("x86_64-unknown-dragonfly"),
#[cfg(target_os = "illumos")]
(b"SunOS", b"i86pc") => Some("x86_64-unknown-illumos"),
#[cfg(target_os = "solaris")]
(b"SunOS", b"i86pc") => Some("x86_64-pc-solaris"),
(b"SunOS", b"sun4v") => Some("sparcv9-sun-solaris"),
_ => None,
};

Expand Down
8 changes: 8 additions & 0 deletions src/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ pub fn this_host_triple() -> String {
"powerpc64le"
} else if cfg!(target_arch = "s390x") {
"s390x"
} else if cfg!(target_arch = "sparc64") {
"sparcv9"
} else {
unimplemented!()
};
Expand All @@ -168,6 +170,12 @@ pub fn this_host_triple() -> String {
"unknown-illumos"
} else if cfg!(target_os = "freebsd") {
"unknown-freebsd"
} else if cfg!(target_os = "solaris") {
if cfg!(target_arch = "sparc64") {
"sun-solaris"
} else {
"pc-solaris"
}
} else {
unimplemented!()
};
Expand Down
2 changes: 1 addition & 1 deletion www/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ <h2>An installer for the systems programming language <a href="https://www.rust-
<!-- unrecognized platform: ask for help -->
<p>I don't recognize your platform.</p>
<p>
rustup runs on Windows, Linux, macOS, FreeBSD, NetBSD, and illumos. If
rustup runs on Windows, Linux, macOS, FreeBSD, NetBSD, Solaris and illumos. If
you are on one of these platforms and are seeing this then please
<a href="https://github.com/rust-lang/rustup/issues/new">report an issue</a>,
along with the following values:
Expand Down