Skip to content

add Solaris support #4380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

add Solaris support #4380

merged 1 commit into from
Jun 10, 2025

Conversation

psumbera
Copy link
Contributor

@psumbera psumbera commented Jun 9, 2025

Rustup should be built also for Solaris (after rust-lang/rust#138699).

@psumbera psumbera force-pushed the solaris-ci branch 2 times, most recently from b733d4d to 5d88e4b Compare June 9, 2025 13:16
@rami3l
Copy link
Member

rami3l commented Jun 9, 2025

@psumbera Thanks for your contribution! Have you (temporarily) removed skip-pr to get a CI run to prove the correctness of this PR though?

@psumbera
Copy link
Contributor Author

psumbera commented Jun 9, 2025

@psumbera Thanks for your contribution! Have you (temporarily) removed skip-pr to get a CI run to prove the correctness of this PR though?

No. To be honest I'm trying to find out how it's working...

So I removed them from ci/actions-templates/linux-builds-template.yaml for now.

@rami3l
Copy link
Member

rami3l commented Jun 9, 2025

@psumbera As a friendly hint, we often do it like so: do the normal PR first, add a DROP ME commit on top that does the temporary hack, and when the CI turns green, rebase the PR and drop that commit.

@rami3l
Copy link
Member

rami3l commented Jun 9, 2025

@psumbera Thanks for your contribution! Have you (temporarily) removed skip-pr to get a CI run to prove the correctness of this PR though?

No. To be honest I'm trying to find out how it's working...

So I removed them from ci/actions-templates/linux-builds-template.yaml for now.

@psumbera That's right, but you'll also need to run the shell script to update the GitHub CI YAML to keep them in sync, otherwise the CI will fail anyway.

@psumbera psumbera force-pushed the solaris-ci branch 2 times, most recently from 90b2501 to b7170ec Compare June 9, 2025 14:07
@rami3l rami3l linked an issue Jun 9, 2025 that may be closed by this pull request
@psumbera psumbera force-pushed the solaris-ci branch 4 times, most recently from df3ac91 to 7980c8c Compare June 9, 2025 15:10
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this PR, and LGTM (modulo the comments)!

@rami3l rami3l added this pull request to the merge queue Jun 10, 2025
Merged via the queue into rust-lang:master with commit 452c8e5 Jun 10, 2025
29 checks passed
@rami3l
Copy link
Member

rami3l commented Jun 11, 2025

@psumbera Many thanks again for your contribution!

As a follow-up question, is browser detection on https://dev.rustup.rs working alright on Solaris? (I assume it's working alright on x64, but you are adding support for sparcv9 in this PR as well which seems to be an architecture never supported before by rustup, so I'm a bit concerned.)

For example, for other unices we have:

rustup/www/rustup.js

Lines 36 to 40 in 452c8e5

if (navigator.platform == "FreeBSD x86_64") {os = "unix";}
if (navigator.platform == "FreeBSD amd64") {os = "unix";}
if (navigator.platform == "NetBSD x86_64") {os = "unix";}
if (navigator.platform == "NetBSD amd64") {os = "unix";}
if (navigator.platform == "SunOS i86pc") {os = "unix";}

@psumbera
Copy link
Contributor Author

As a follow-up question, is browser detection on https://dev.rustup.rs working alright on Solaris? (I assume it's working alright on x64, but you are adding support for sparcv9 in this PR as well which seems to be an architecture never supported before by rustup, so I'm a bit concerned.)

So far I wasn't able to test it. curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs still returns the script without my changes.

@rami3l
Copy link
Member

rami3l commented Jun 11, 2025

So far I wasn't able to test it.

@psumbera Sorry for not being clear enough previously; I meant the Web frontend part of the detection specifically, since we'd normally assume a host platform (anything tier 1, or tier 2 with host tools) can run a browser and the user might want to go to the website for installation instructions.

curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs still returns the script without my changes.

This is expected; merging the PR only gets it into our code base and the actual deployment will happen in the next release. Although I cannot say for sure when that will come, I'd say that we are trying our best to make releases happen more often.

@psumbera
Copy link
Contributor Author

As a follow-up question, is browser detection on https://dev.rustup.rs working alright on Solaris? (I assume it's working alright on x64, but you are adding support for sparcv9 in this PR as well which seems to be an architecture never supported before by rustup, so I'm a bit concerned.)

See attached screen shot what I get on Solaris SPARC in Firefox 128.9.0. I think it's ok.

Screenshot 2025-06-11 at 9 25 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SunOS/Solaris/Illumos support
2 participants