This repository was archived by the owner on Nov 24, 2023. It is now read-only.
Improve tests #31
Merged
Improve tests #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killercup
approved these changes
May 18, 2017
There was a problem hiding this comment.
Better than before.
I still want to refactor this to get rid of some of the nested for loops, e.g. by flatmapping the source beforehand and then iterating over items that have all the relevant info the actual logic, which we should also put into some named functions. But, this is a test, so it's no priority :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave up on #29 ... I got build failures for the submodule on travis that I couldn't reproduce locally. I even did a clean checkout of the repo and followed what travis did line for line...
So here's the general part