Add a new submodule for running rustfix on #29
Conversation
tests/fixtures.rs
Outdated
| fixture_path.join(path.trim()) | ||
| } else { | ||
| fixture_path.clone() | ||
| }; |
There was a problem hiding this comment.
So, we now have files that tell us which directory to look into for applying fixtures? Why not allow multiple sub paths to check? I'd probably start refactoring the whole nested for loop business with a bunch of flat_maps now going from crate folders to tests.
There was a problem hiding this comment.
yea that's the next step :)
tests/tests/trust-dns/yolo/diff.diff
Outdated
| /// returns the high 12 bits for the edns portion of the response code | ||
| pub fn high(&self) { | ||
| - (u16::from(*self) & 0x0FF0) >> 4; | ||
| + (u16::from(*self) & 0x0FF0);4; |
|
I have no clue how the tests are failing... they work locally... |
|
I this because of different versions of diff maybe? (If you're using macos, you might have bsd diff and travis is using gnu diff or something like that.) I haven't read the output, though. (How would we even debug that? A diff of a diff? :D) Also, for checking the output it might be nice to disable colored output. Don't know if the crate we are using has an override for that, though. |
|
I like it with the colors. I can do |
|
It might also be that we don't get things in the same order every time we run rustfix. I'll investigate |
|
whoops |
No description provided.