Skip to content

various fixes/improvements to Contributing chapter #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 8, 2023
Merged

various fixes/improvements to Contributing chapter #1723

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a8b9990
separate link target from normal content
tshepang Jul 5, 2023
0104117
avoid needless markdown linking noise
tshepang Jul 5, 2023
2136d25
generalise
tshepang Jul 5, 2023
51071c5
make sentence more simple, and account for moved info
tshepang Jul 5, 2023
487bb7e
share a link reference
tshepang Jul 5, 2023
1cb1969
avoid needless markdown linking noise (again)
tshepang Jul 5, 2023
7bd47cf
make sentence more readable
tshepang Jul 5, 2023
991564e
feels like a sidenote
tshepang Jul 5, 2023
70f1f5e
improve wording a little
tshepang Jul 5, 2023
16caa05
missing pluralisation and comma
tshepang Jul 5, 2023
cc3ba5c
separate link target from normal content (again)
tshepang Jul 5, 2023
103da3c
missing comma
tshepang Jul 5, 2023
3eaefbd
avoid needless markdown linking noise (once more)
tshepang Jul 5, 2023
41eee42
avoid repetition
tshepang Jul 5, 2023
b523eaf
separate link target from normal content (once more)
tshepang Jul 5, 2023
4966e99
semantic line breaks
tshepang Jul 5, 2023
b855ac0
avoid needless markdown linking noise (yet again)
tshepang Jul 5, 2023
573c0b9
semantic line breaks
tshepang Jul 5, 2023
2d0f66d
avoid title case
tshepang Jul 5, 2023
bbf31db
avoid needless markdown linking noise (last time this time)
tshepang Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make sentence more simple, and account for moved info
  • Loading branch information
@tshepang
tshepang committed Jul 5, 2023
commit 51071c58fdca3badd746617bf8aeecdc57fb7a2a
8 changes: 4 additions & 4 deletions src/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,13 +174,13 @@ Zulip ([#t-release/triage]). They have knowledge of when to ping, who might be
on vacation, etc.

The reviewer may request some changes using the GitHub code review interface.
They may also request special procedures (such as a [crater] run; [see
below][break]) for some PRs.
They may also request special procedures for some PRs.
See [Crater] and [Breaking Changes] chapters for some examples of such procedures.

[r?]: https://github.com/rust-lang/rust/pull/78133#issuecomment-712692371
[#t-release/triage]: https://rust-lang.zulipchat.com/#narrow/stream/242269-t-release.2Ftriage
[break]: #breaking-changes
[crater]: tests/crater.md
[Breaking Changes]: bug-fix-procedure.md
[Crater]: tests/crater.md

### CI

Expand Down