Skip to content

various fixes/improvements to Contributing chapter #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 8, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
avoid needless markdown linking noise (once more)
  • Loading branch information
tshepang committed Jul 5, 2023
commit 3eaefbd4ea946247948ce42ff1a8f1cb16783c4d
9 changes: 4 additions & 5 deletions src/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,9 @@ See [Crater] and [Breaking Changes] chapters for some examples of such procedure
In addition to being reviewed by a human, pull requests are automatically tested,
thanks to continuous integration (CI). Basically, every time you open and update
a pull request, CI builds the compiler and tests it against the
[compiler test suite][rctd], and also performs other tests such as checking that
[compiler test suite], and also performs other tests such as checking that
your pull request is in compliance with Rust's style guidelines.

[rctd]: tests/intro.md

Running continuous integration tests allows PR authors to catch mistakes early
without going through a first review cycle, and also helps reviewers stay aware
of the status of a particular pull request.
Expand All @@ -207,7 +205,7 @@ on the pull request with an `r+`. It will look something like this:
@bors r+

This tells [@bors], our lovable integration bot, that your pull request has
been approved. The PR then enters the [merge queue][merge-queue], where [@bors]
been approved. The PR then enters the [merge queue], where [@bors]
will run *all* the tests on *every* platform we support. If it all works out,
[@bors] will merge your code into `master` and close the pull request.

Expand All @@ -224,7 +222,6 @@ Be patient; this can take a while and the queue can sometimes be long. PRs are n

[@rustbot]: https://github.com/rustbot
[@bors]: https://github.com/bors
[merge-queue]: https://bors.rust-lang.org/queue/rust

### Opening a PR

Expand Down Expand Up @@ -474,3 +471,5 @@ This section has moved to the ["About this guide"][more-links] chapter.
[Breaking Changes]: bug-fix-procedure.md
[triagebot.toml config file]: https://github.com/rust-lang/rust/blob/HEAD/triagebot.toml
[rust-lang teams database]: https://github.com/rust-lang/team/tree/HEAD/teams
[compiler test suite]: tests/intro.md
[merge queue]: https://bors.rust-lang.org/queue/rust