Skip to content

Conversation

@FoseFx
Copy link
Contributor

@FoseFx FoseFx commented Mar 24, 2022

Adding the following diagnostic items:

  • str_split_whitespace,
  • str_trim,
  • str_trim_start,
  • str_trim_end

They are needed for rust-lang/rust-clippy#8575

r? @flip1995

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 24, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2022
@flip1995
Copy link
Member

Thanks! Naming of those diagnostic items is in accordance with the naming of the diagnostic items in the mem module, so this seems like a good naming for those functions.

@bors r+ rollup

@flip1995
Copy link
Member

@bors r-

Whoops too trigger happy on that r+

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2022
@FoseFx FoseFx force-pushed the clippy_trim_split_whitespace branch from e686ab5 to 64ad96d Compare March 24, 2022 17:19
@flip1995
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 24, 2022

📌 Commit 64ad96d has been approved by flip1995

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 24, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#94391 (Fix ice when error reporting recursion errors)
 - rust-lang#94655 (Clarify which kinds of MIR are allowed during which phases.)
 - rust-lang#95179 (Try to evaluate in try unify and postpone resolution of constants that contain inference variables)
 - rust-lang#95270 (debuginfo: Fix debuginfo for Box<T> where T is unsized.)
 - rust-lang#95276 (add diagnostic items for clippy's `trim_split_whitespace`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3716c42 into rust-lang:master Mar 25, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 25, 2022
@FoseFx FoseFx deleted the clippy_trim_split_whitespace branch March 25, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants