-
Notifications
You must be signed in to change notification settings - Fork 1.8k
add trim_split_whitespace
#8575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
…, r=flip1995 add diagnostic items for clippy's `trim_split_whitespace` Adding the following diagnostic items: * str_split_whitespace, * str_trim, * str_trim_start, * str_trim_end They are needed for rust-lang/rust-clippy#8575 r? `@flip1995`
|
To use the diagnostic items in this PR, you can try to bump the nightly version in the (You can only do this once this nightly is released in about 4-7 hours, obviously) |
|
There is a different test failing on |
|
☔ The latest upstream changes (presumably #8576) made this pull request unmergeable. Please resolve the merge conflicts. |
d418857 to
10a1ec8
Compare
|
☔ The latest upstream changes (presumably #8594) made this pull request unmergeable. Please resolve the merge conflicts. |
10a1ec8 to
e4b2285
Compare
|
Blocked on the sync on Thursday |
e4b2285 to
570c34f
Compare
|
Looks like the tests are missing the edge case where the type implements Otherwise it's looking good. I tested on a bunch of top crates. I found 3 warnings in |
52c6157 to
1216903
Compare
|
☔ The latest upstream changes (presumably #8626) made this pull request unmergeable. Please resolve the merge conflicts. |
1216903 to
90308a3
Compare
|
☔ The latest upstream changes (presumably #8711) made this pull request unmergeable. Please resolve the merge conflicts. |
90308a3 to
0d692c2
Compare
|
☔ The latest upstream changes (presumably #8727) made this pull request unmergeable. Please resolve the merge conflicts. |
98d8b5e to
f37ed5d
Compare
|
poke |
flip1995
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM me overall. Small suggestion on how to improve the suggestion.
|
👍 |
flip1995
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Can you squash the commits? After that, this is ready to get merged.
2b149c2 to
fea177f
Compare
|
Done 👍 |
|
Thanks! Sorry reviews take so long currently... @bors r+ |
|
📌 Commit fea177f has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Closes #8521
changelog: [
trim_split_whitespace]