Add x.py check src/librustdoc as an alias for x.py check src/tools/rustdoc#84585
Add x.py check src/librustdoc as an alias for x.py check src/tools/rustdoc#84585bors merged 1 commit intorust-lang:masterfrom
x.py check src/librustdoc as an alias for x.py check src/tools/rustdoc#84585Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
src/bootstrap/check.rs
Outdated
There was a problem hiding this comment.
This is not quite right -- we likely want to use paths(&[...]) here, which sets up a set of paths all describing the same thing, rather than different things on the same Step. We're not always consistent about that but it's the intended API usage.
This is basically intended to support the use case of test library/core library/std not testing alloc; these checks don't really support it anyway, but I'd prefer to use the right API. If it's a pain to make the macro play nice with that then no worries.
There was a problem hiding this comment.
Sure thing, done. It was pretty simple:
diff --git a/src/bootstrap/check.rs b/src/bootstrap/check.rs
index 786cca14863..536843d4ec2 100644
--- a/src/bootstrap/check.rs
+++ b/src/bootstrap/check.rs
@@ -292,7 +292,7 @@ impl Step for $name {
const DEFAULT: bool = true;
fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
- run.path($path) $(.path($alias))*
+ run.paths(&[ $path, $($alias),* ])
}
fn make_run(run: RunConfig<'_>) {|
r=me with nit fixed if it's not too hard, otherwise just r=me |
|
@bors r=Mark-Simulacrum rollup |
|
📌 Commit b28754a has been approved by |
…crum Add `x.py check src/librustdoc` as an alias for `x.py check src/tools/rustdoc` I keep making this typo, it would be nice for it to be supported.
…crum Add `x.py check src/librustdoc` as an alias for `x.py check src/tools/rustdoc` I keep making this typo, it would be nice for it to be supported.
…crum Add `x.py check src/librustdoc` as an alias for `x.py check src/tools/rustdoc` I keep making this typo, it would be nice for it to be supported.
Rollup of 11 pull requests Successful merges: - rust-lang#84484 (Don't rebuild rustdoc and clippy after checking bootstrap) - rust-lang#84530 (`test tidy` should ignore alternative `build` dir patterns) - rust-lang#84531 (Ignore commented out lines when finding features) - rust-lang#84540 (Build sanitizers for x86_64-unknown-linux-musl) - rust-lang#84555 (Set `backtrace-on-ice` by default for compiler and codegen profiles) - rust-lang#84585 (Add `x.py check src/librustdoc` as an alias for `x.py check src/tools/rustdoc`) - rust-lang#84636 (rustdoc: change aliases attribute to data-aliases) - rust-lang#84646 (Add some regression tests related to rust-lang#82494) - rust-lang#84661 (Remove extra word in `rustc_mir` docs) - rust-lang#84663 (Remove `DropGuard` in `sys::windows::process` and use `StaticMutex` instead) - rust-lang#84668 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
I keep making this typo, it would be nice for it to be supported.