Adjust the error messages to match the pattern "expected foo, found bar" #8314

kud1ing · 2013-08-05T20:13:08Z

... which the coding style guide suggests.

Use unchecked vec indexing since the vector bounds are checked by the loop. Iterators are not easy to use in this case since we skip 1-4 bytes each lap. This part of the commit speeds up is_utf8 for ASCII input. Check codepoint ranges by checking the byte ranges manually instead of computing a full decoding for multibyte encodings. This is easy to read and corresponds to the UTF-8 syntax in the RFC. No changes to what we accept. A comment notes that surrogate halves are accepted. Before: test str::bench::is_utf8_100_ascii ... bench: 165 ns/iter (+/- 3) test str::bench::is_utf8_100_multibyte ... bench: 218 ns/iter (+/- 5) After: test str::bench::is_utf8_100_ascii ... bench: 130 ns/iter (+/- 1) test str::bench::is_utf8_100_multibyte ... bench: 156 ns/iter (+/- 3)

multicast functions now take IpAddr (without port), because they dont't need port. Uv* types renamed: * UvIpAddr -> UvSocketAddr * UvIpv4 -> UvIpv4SocketAddr * UvIpv6 -> UvIpv6SocketAddr "Socket address" is a common name for (ip-address, port) pair (e.g. in sockaddr_in struct).

I suspect that this is a race between process exit and the termination of worker threads used by libuv (if I sleep before exit it doesn't leak). This isn't going to cause any real problems but should probably be fixed at some point.

Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>

rvalues aren't going to be used anywhere but as the argument, so there's no point in copying them. LLVM used to eliminate the copy later, but why bother emitting it in the first place?

Useful for SDL and possibly Android too.

These are both obsoleted by the forthcoming new GC.

(issue #4604)

…acro

* LLVM now has a C interface to LLVMBuildAtomicRMW * The exception handling support for the JIT seems to have been dropped * Various interfaces have been added or headers have changed

At the same time create a more robust wrapper to try to prevent this type of issue from cropping up in the future.

Thanks @luqama!

It was previously pushing the byte on top of the string's null terminator. I added a test to make sure it doesn't break in the future.

Also fix some incorrect comments and variable names.

Otherwise interferes with the existing runtime

rustc needs *even more* megabytes when run without optimizations

Every time run_sched_once performs a 'scheduling action' it needs to guarantee that it runs at least one more time, so enqueue another run_sched_once callback. The primary reason it needs to do this is because not all async callbacks are guaranteed to run, it's only guaranteed that *a* callback will run after enqueing one - some may get dropped. At the moment this means we wastefully create lots of callbacks to ensure that there will *definitely* be a callback queued up to continue running the scheduler. The logic really needs to be tightened up here.

This is no longer testable once newsched is turned on

Not compatible with newsched

Closes #5506.

Closes #4430

- Made naming schemes consistent between Option, Result and Either - Changed Options Add implementation to work like the maybe monad (return None if any of the inputs is None) - Removed duplicate Option::get and renamed all related functions to use the term `unwrap` instead

…apparent 11% speedup.

Let Option be a base for a widely useful one- or zero- item iterator. Refactor OptionIterator to support any generic element type, so the same iterator impl can be used for both &T, &mut T and T iterators.

convert iter() and iter_err() for Result. Use OptionIterator.

Implement clone, bidirectionality and random access for this iterator

Use the Repeat iterator to carry the "explicit closure capture" that was previously done with the custom EnvFilterIterator.

With Option as the simplest container, `consume` is the way to turn it into a by-value iterator.

ChunkIter .idx() didn't handle overflow correctly, even though it tried.

kud1ing · 2013-08-06T20:32:21Z

Sorry, that was a merge instead of a rebase. For now i am a lost in rebase-land.

Seldaek · 2013-08-07T09:51:12Z

@kud1ing your best bet at this point is to start over I think:

git checkout but_found
git fetch <mozilla/rust remote>
git reset --hard <mozilla/rust remote>/master
git cherry-pick 113cc0e # that's your initial commit
resolve the conflicts you'll have when applying
git add src/lib*
git commit

where <mozilla/rust remote> is origin, upstream or whatever you called the remote with this repo in.

kud1ing · 2013-08-07T10:09:55Z

@Seldaek: Thanks. A painful but important lesson.

kud1ing · 2013-08-07T18:09:20Z

I give up. LLVM patches could not be applied.

Lenny222 and others added 30 commits August 5, 2013 22:09

adjust error message to coding style

113cc0e

rebase

10c1853

rebase

8129655

Suppress a libuv leak on mac

48e1af8

I suspect that this is a race between process exit and the termination of worker threads used by libuv (if I sleep before exit it doesn't leak). This isn't going to cause any real problems but should probably be fixed at some point.

etc: add the in keyword to the emacs mode.

db6ff76

Fix building problems in extra::unicode.

b142077

Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>

trans_arg_expr: Omit extra copies for rvalues

4a09595

rvalues aren't going to be used anywhere but as the argument, so there's no point in copying them. LLVM used to eliminate the copy later, but why bother emitting it in the first place?

Work around #8256, do not fail the task, just return None

0ab4965

librustc: Implement #[no_main], which omits the entry point entirely.

4b4960c

Useful for SDL and possibly Android too.

std: Remove gc and stackwalk

35318b7

These are both obsoleted by the forthcoming new GC.

Additional check in treemap iterator test.

0dcaf07

Remove redundant print.

1b54e40

Implemented TreeMap::{lower_bound_iter,upper_bound_iter}

d946c8c

(issue #4604)

Try to fix a periodic windows build failure due to broken rwildcard m…

f338e04

…acro

Update LLVM

017740d

Fix build issues once LLVM has been upgraded

afd12bf

* LLVM now has a C interface to LLVMBuildAtomicRMW * The exception handling support for the JIT seems to have been dropped * Various interfaces have been added or headers have changed

Fix setting the fixed stack segment attribute on LLVM functions

59e8672

At the same time create a more robust wrapper to try to prevent this type of issue from cropping up in the future.

Add a workaround for 8199 for now

0ebf15c

Integrate new arm patch and fix an LLVM bug

1e39db8

Thanks @luqama!

Fixed str::raw::push_byte

e6dd0ea

It was previously pushing the byte on top of the string's null terminator. I added a test to make sure it doesn't break in the future.

std::rt: Improve the error message when the thread-local ptr is null

9eaeacd

Also fix some incorrect comments and variable names.

std::rt: Run the tests for Local in a bare thread

c589924

Otherwise interferes with the existing runtime

std::rt: 3MB stacks!

d5c4733

rustc needs *even more* megabytes when run without optimizations

std::rt: Remove the test for context()

5d020d1

This is no longer testable once newsched is turned on

Remove old tests and code for select

59a5816

Not compatible with newsched

fix warning still mentioning the again keyword

b14b77a

Implemented iterator for TrieMap

eabb4fa

Closes #5506.

msullivan and others added 21 commits August 6, 2013 22:18

Improve debug spew in _match.

0ba3f91

adjust error message to coding style

b204783

Use TreeMap's ord implementation for Json

2c581e1

Closes #4430

(cleanup) Uncomment an assertion that now holds.

1662f69

Lazily initialize 'leaf node' taskgroups for unlinked spawns, for an …

ed81439

…apparent 11% speedup.

std: Add .consume_iter() for Option, to make it reusable

94f8232

Let Option be a base for a widely useful one- or zero- item iterator. Refactor OptionIterator to support any generic element type, so the same iterator impl can be used for both &T, &mut T and T iterators.

std: Convert Result to use external iterators

55657e6

convert iter() and iter_err() for Result. Use OptionIterator.

std: Remove unused trait bound in Result::map

ecee285

std: Implement RandomAccessIterator for Invert

2c21b99

std: Improve vec::ChunkIter

1c01b1d

Implement clone, bidirectionality and random access for this iterator

std: Add iterator::Repeat to repeat an element endlessly

c2d4812

std: Rewrite the HashSet set operation iterators

a2f116c

Use the Repeat iterator to carry the "explicit closure capture" that was previously done with the custom EnvFilterIterator.

std: Use method name Option::consume

e843b88

With Option as the simplest container, `consume` is the way to turn it into a by-value iterator.

std: Improve the documentation for iterator::Invert

cbbca97

extra: Simplify the bitv iterators using Repeat

f0e345b

std: Remove uint::iterate, replaced by range

eccf370

std: Fix bug in ChunkIter::idx

282fb72

ChunkIter .idx() didn't handle overflow correctly, even though it tried.

Move EnumSet into libextra

26d74df

rebase

ab93bc4

Merge branch 'but_found' of github.com:kud1ing/rust into but_found

ea07e33

kud1ing closed this Aug 7, 2013

kud1ing mentioned this pull request Aug 9, 2013

Adjust the error messages to match the pattern "expected foo, found bar" #8413

Closed

kud1ing mentioned this pull request Aug 13, 2013

Adjust the error messages to match the pattern "expected foo, found bar" #8492

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adjust the error messages to match the pattern "expected foo, found bar" #8314

Adjust the error messages to match the pattern "expected foo, found bar" #8314

Uh oh!

kud1ing commented Aug 5, 2013

Uh oh!

kud1ing commented Aug 6, 2013

Uh oh!

Seldaek commented Aug 7, 2013

Uh oh!

kud1ing commented Aug 7, 2013

Uh oh!

kud1ing commented Aug 7, 2013

Uh oh!

Uh oh!

Adjust the error messages to match the pattern "expected foo, found bar" #8314

Adjust the error messages to match the pattern "expected foo, found bar" #8314

Uh oh!

Conversation

kud1ing commented Aug 5, 2013

Uh oh!

kud1ing commented Aug 6, 2013

Uh oh!

Seldaek commented Aug 7, 2013

Uh oh!

kud1ing commented Aug 7, 2013

Uh oh!

kud1ing commented Aug 7, 2013

Uh oh!

Uh oh!