Adjust the error messages to match the pattern "expected foo, found bar" #8413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly I did simple transformations from imperative style loops to more functional iterator based transformations.
…lock for O(n) time, cf #3100, and optimize out several unneeded clone()s.
Since the new runtime landed, the *-nopt builders have increased cycle time by roughly an hour. I have a feeling that this is because the entire runtime is in rust and it's not being optimized at all. In that past with an optimized C++ runtime it looks like things ran faster. This adds the ability to disable optimizations in tests only, not for the entire compiler. This means that the entire compiler and associated libraries will be built with optimizations, but the tests themselves would be built and run without optimizations. This isn't quite as good of a guarantee as disabling optimizations everywhere, but hopefully it'll improve cycle time for the *-nopt builds to move the queue along faster.
I did this once but acciddentally undid it in a later patch.
Mostly I did simple transformations from imperative style loops to more functional iterator based transformations.
Each commit is pretty much what it says on the tin. r anybody.
|
I don't know whether i do the rebasing correctly. The diff is getting less readable each time, since it accumulates other commits. |
|
The tests do not pass due to the other commits. I really have no idea how to get this through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as suggested by the coding style guide.
This is a clean retry of PR #8314 which i screwed up in rebase-land.
@pcwalton: r?