Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert dist-x86_64-linux update to Clang 11 #81565

Merged
merged 1 commit into from
Jan 30, 2021
Merged

Revert dist-x86_64-linux update to Clang 11 #81565

merged 1 commit into from
Jan 30, 2021

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Jan 30, 2021

This reverts commit cb6787a, reversing changes made to 0248c6f.

The change causes errors when linking rustc shared objects with the binutils linker.

Fixes #81554.

r? @Mark-Simulacrum

@nikic
Revert "Auto merge of rust-lang#81489 - nikic:x86-64-dist-update, r=M…
8c7611c 
…ark-Simulacrum"

This reverts commit cb6787a, reversing
changes made to 0248c6f.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2021
@nikic nikic mentioned this pull request Jan 30, 2021
Closed
@nagisa
Copy link
Member

nagisa commented Jan 30, 2021

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jan 30, 2021

📌 Commit 8c7611c has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2021
@RalfJung
Copy link
Member

@bors p=99
hopefully this gets in before it affects a nightly

@m-ou-se
Copy link
Member

m-ou-se commented Jan 30, 2021

hopefully this gets in before it affects a nightly

This won't make it if #81560 first runs to completion. There's a bit more than three hours left to make the next nightly.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jan 30, 2021
Merged
@bors
Copy link
Contributor

bors commented Jan 30, 2021

⌛ Testing commit 8c7611c with merge 04caa63...

@m-ou-se
Copy link
Member

m-ou-se commented Jan 30, 2021 •
edited
Loading

Only 10 minutes left. Go dist-aarch64-apple, go!

🏁 🐌 💨

@bors
Copy link
Contributor

bors commented Jan 30, 2021

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 04caa63 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 30, 2021
@bors bors merged commit 04caa63 into rust-lang:master Jan 30, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.

Latest master toolchains are broken when linking LLVM: "__morestack: invalid needed version 2"
8 participants
@nikic @nagisa @bors @RalfJung @m-ou-se @Mark-Simulacrum @rust-highfive @rustbot