Update Clippy #81560
Merged
Update Clippy #81560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes rust-lang#6503 changelog: match_like_matches_macro: strip refs in suggestion (rust-lang#6503)
Closes rust-lang#6425 Looks for ends_with methods calls with case sensitive extensions.
This was left as default and caused a CI failure for the case_sensitive_file_extension_comparison lint.
It happened because `zero_sized_map_values` used `layout_of` with types from type aliases, which is essentially the same as the ICE 4968.
Add: attempt to remove address of expressions from the scrutinee expression before adding references to the pattern
Remove duplication in the manual_ok_or lint example changelog: none
…labels_to_doc, r=flip1995 Add notes of prioritization labels to doc Refer to https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/New.20prioritization.20labels. changelog: none
single_match: suggest `if` over `if let` when possible fixes: rust-lang#173 changelog: single_match: suggest `if` over `if let` when possible
…sions, r=llogiq Case sensitive file extensions Closes rust-lang#6425 Looks for ends_with methods calls with case sensitive extension comparisons. changelog: Add new lint that warns about case-sensitive file extension comparisons.
Co-authored-by: Philipp Krones <hello@philkrones.com>
This is now handled by unknown_lints
…jasper Make more traits of the From/Into family diagnostic items Following traits are now diagnostic items: - `From` (unchanged) - `Into` - `TryFrom` - `TryInto` This also adds symbols for those items: - `into_trait` - `try_from_trait` - `try_into_trait` Related: rust-lang/rust-clippy#6620 (comment)
Improve safety of `LateContext::qpath_res` This is my first rustc code change, inspired by hacking on clippy! The first change is to clear cached `TypeckResults` from `LateContext` when visiting a nested item. I took a hint from [here](https://github.com/rust-lang/rust/blob/5e91c4ecc09312d8b63d250a432b0f3ef83f1df7/compiler/rustc_privacy/src/lib.rs#L1300). Clippy has a `qpath_res` util function to avoid a possible ICE in `LateContext::qpath_res`. But the docs of `LateContext::qpath_res` promise no ICE. So this updates the `LateContext` method to keep its promises, and removes the util function. Related: rust-lang/rust-clippy#4545 CC ````````````@eddyb```````````` since you've done related work CC ````````````@flip1995```````````` FYI
Rustup changelog: Deprecate `unknown_clippy_lints` (integrated in `unknown_lints`) r? `@ghost`
No lazy static regex r? `@llogiq` rust-lang#6500 regex is unnecessary for this lint (rust-lang/rust-clippy#6500 (comment)) lazy_static is unnecessary. The std lazy feature should be used instead. changelog: none
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ p=1 |
Collaborator
|
📌 Commit 21758bf has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 21758bf with merge 3c29309c0e083871e256953296ff8e13db0d0ea3... |
Member
Member
Member
|
Oh, race condition. :) |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Jan 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
29 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth
Biweekly Clippy update (2 days late)