Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder vec bench extend recycle #77185

Closed
wants to merge 1 commit into from
Closed

Conversation

pickfire
Copy link
Contributor

Superseeds #76357

r? @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 25, 2020

I still don't really understand the point of this change.

@pickfire
Copy link
Contributor Author

pickfire commented Sep 25, 2020

Reordering the benchmark, if you look at the whole file you will understand. It just pops out randomly so I just make it easier to read.

@LeSeulArtichaut LeSeulArtichaut added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2020
@Dylan-DPC-zz
Copy link

Looks like there is no motivation for this pr and don't want to end up with dozens of pr reordering benchmarks :P

@pickfire pickfire deleted the patch-3 branch October 17, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants