Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder vec bench extend recycle #76357

Closed
wants to merge 1 commit into from
Closed

Reorder vec bench extend recycle #76357

wants to merge 1 commit into from

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Sep 5, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 15, 2020

Can you describe why this is a useful change? It looks like it's just moving around code.

@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Sep 15, 2020
@pickfire
Copy link
Contributor Author

@jyn514 Yes, that's what I am doing here. I move it around to keep with similar code, all recycle bench are there but this one is alone, so lonely.

@bors
Copy link
Contributor

bors commented Sep 25, 2020

☔ The latest upstream changes (presumably #77172) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@pickfire pickfire closed this Sep 25, 2020
@pickfire pickfire deleted the patch-3 branch September 25, 2020 14:20
@pickfire pickfire mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pickfire @rust-highfive @jyn514 @bors @joshtriplett