Skip to content

Don't italicize comments in ayu theme #74790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2020
Merged

Don't italicize comments in ayu theme #74790

merged 1 commit into from
Jul 27, 2020

Conversation

@Cldfire
Copy link
Contributor

@Cldfire Cldfire commented Jul 26, 2020

Closes #74770.

Before:

image

After:

image

@rust-highfive
Copy link
Contributor

rust-highfive commented Jul 26, 2020

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

A change occurred in the Ayu theme.

cc @Cldfire

@rust-highfive
Copy link
Contributor

rust-highfive commented Jul 26, 2020

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2020
@Cldfire
Copy link
Contributor Author

Cldfire commented Jul 26, 2020

r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jul 26, 2020

Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 26, 2020

📌 Commit 51b99d4 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2020
@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 27, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 27, 2020
@Manishearth
Rollup merge of rust-lang#74790 - Cldfire:ayu-no-italic-comments, r=G…
90c590f 
…uillaumeGomez

Don't italicize comments in ayu theme

Closes rust-lang#74770.

Before:

![image](https://user-images.githubusercontent.com/13814214/88486217-2bf18700-cf4a-11ea-896d-e7787b94e7a7.png)

After:

![image](https://user-images.githubusercontent.com/13814214/88486225-3a3fa300-cf4a-11ea-929f-90461799dc01.png)
@Manishearth Manishearth mentioned this pull request Jul 27, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Jul 27, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 27, 2020
@bors
Auto merge of rust-lang#74817 - JohnTitor:rollup-0fchdye, r=JohnTitor
52d2c7a 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#74088 (Avoid writes without any data in `Write::write_all_vectored`)
 - rust-lang#74598 (Fix sync_once_cell_does_not_leak_partially_constructed_boxes)
 - rust-lang#74750 (Clean up some uses of logging in ui tests)
 - rust-lang#74783 (python codes cleanup)
 - rust-lang#74790 (Don't italicize comments in ayu theme)
 - rust-lang#74799 (Fixed typo in `closure`)

Failed merges:

r? @ghost
@bors bors merged commit 0042e41 into rust-lang:master Jul 27, 2020
@lqd lqd mentioned this pull request Jun 14, 2022
Closed
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

Ayu: Please don't make comment italic. Instead mark it with different color than doc comment.

7 participants

@Cldfire @rust-highfive @GuillaumeGomez @bors @cuviper @nikomatsakis @jyn514