Clean up some uses of logging in ui tests #74750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @JohnTitor |
JohnTitor
reviewed
Jul 25, 2020
JohnTitor
approved these changes
Jul 26, 2020
|
r? @JohnTitor @bors r=JohnTitor |
|
📌 Commit 86ac65c has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 27, 2020
…r=JohnTitor Clean up some uses of logging in ui tests The removed test can't possibly trigger anything today as we don't have logging in libstd. The `exec-env` flag was mistakenly used for adding env vars to rustc invocations both in test and in the test suite and there were some accidental renames from RUST_LOG to RUSTC_LOG that I reverted.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 27, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#74088 (Avoid writes without any data in `Write::write_all_vectored`) - rust-lang#74598 (Fix sync_once_cell_does_not_leak_partially_constructed_boxes) - rust-lang#74750 (Clean up some uses of logging in ui tests) - rust-lang#74783 (python codes cleanup) - rust-lang#74790 (Don't italicize comments in ayu theme) - rust-lang#74799 (Fixed typo in `closure`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed test can't possibly trigger anything today as we don't have logging in libstd.
The
exec-envflag was mistakenly used for adding env vars to rustc invocations both in test and in the test suite and there were some accidental renames from RUST_LOG to RUSTC_LOG that I reverted.