trans::glue: don't generate struct destructors in the free glue #7159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The free glue shouldn't be called for structs, and the drop glue already contains the destructor.
bors
added a commit
that referenced
this pull request
Jun 16, 2013
The free glue shouldn't be called for structs, and the drop glue already contains the destructor.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 4, 2021
Add unit-hash lint changelog: [`unit_hash`] Add lint for hashing unit values This will lint for situations where the end user is attempting to hash a unit value (`()`), as the implementation in `std` simply [does nothing][impl]. Closes rust-lang#7159 . Example: ```rust ().hash(&mut state); // Should (probably) be replaced with: 0_u8.hash(&mut state); ``` [impl]: https://github.com/rust-lang/rust/blob/a5f164faad4a2fed606b8160fd7ecd2d5cbba381/library/core/src/hash/mod.rs#L656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The free glue shouldn't be called for structs, and the drop glue already
contains the destructor.