Minor cleanup of hashmap #7875
Minor cleanup of hashmap #7875
Conversation
| Some(v) => v, | ||
| None => fail!("No entry found for key: %?", k), | ||
| } | ||
| self.find(k).expect(fmt!("No entry found for key: %?", k)) |
There was a problem hiding this comment.
This might actually be a substantial perf regression. Before, there was no allocation performed unless failure, but this unconditionally allocates a format string. Would you mind benchmarking to see if this is an issue?
There was a problem hiding this comment.
It will definitely be a performance issue to have allocations in any of these code paths. The only allocations it does do are the amortized resizes.
|
Your right alexcrichton |
|
@sstewartgallus I don't think there are any |
|
None of the micro-benchmarks seem to target the get methods so I'm leaving the expect changes off this pull request for now. I, or someone else can add those kind of changes later after I make a different pull request that adds some more benchmarks targeting std::hashmap. |
|
@sstewartgallus: needs to be rebased already |
Add unit-hash lint changelog: [`unit_hash`] Add lint for hashing unit values This will lint for situations where the end user is attempting to hash a unit value (`()`), as the implementation in `std` simply [does nothing][impl]. Closes rust-lang#7159 . Example: ```rust ().hash(&mut state); // Should (probably) be replaced with: 0_u8.hash(&mut state); ``` [impl]: https://github.com/rust-lang/rust/blob/a5f164faad4a2fed606b8160fd7ecd2d5cbba381/library/core/src/hash/mod.rs#L656
No description provided.