Fix position source code files toggle #60383
Conversation
rust-highfive
added
the
S-waiting-on-review
| @@ -1228,6 +1228,39 @@ h4 > .important-traits { | |||
| margin: 5px 0; | |||
| } | |||
|
|
|||
| #sidebar-toggle { | |||
| position: fixed; | |||
There was a problem hiding this comment.
What was actually changed here? Moving the lines up makes it harder to see the actual diff.
There was a problem hiding this comment.
Just look at the first commit. I splitted the changed so you can review easily.
There was a problem hiding this comment.
I am looking at the first commit, it's still harder to tell what was added
There was a problem hiding this comment.
Ah, the only change is adding the stuff to the media query.
| @@ -1261,7 +1138,177 @@ h4 > .important-traits { | |||
| margin-bottom: 6px; | |||
| } | |||
|
|
|||
| .theme-picker { | |||
| position: absolute; | |||
There was a problem hiding this comment.
Does this commit just move entries around, or does it actually change any semantics too?
There was a problem hiding this comment.
The second commit is a cleanup.
|
☔ The latest upstream changes (presumably #60389) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
fix-position-source-code-files-toggle
branch
from
d10efde
to
87d1c17
Compare
|
ping from triage @Manishearth waiting for your review on this |
|
@bors r+ |
|
📌 Commit 87d1c17 has been approved by |
bors
added
S-waiting-on-bors
…code-files-toggle, r=Manishearth Fix position source code files toggle Fixes rust-lang#60381. The second commit is a big cleanup of the media queries. r? @rust-lang/rustdoc cc @Manishearth screenshot of the fix: <img width="501" alt="Screenshot 2019-04-29 at 23 42 56" src="https://user-images.githubusercontent.com/3050060/56929111-112b2b00-6ad9-11e9-9a23-e0a8e3641395.png">
Rollup of 11 pull requests Successful merges: - #60383 (Fix position source code files toggle) - #60453 (Fall back to `/dev/urandom` on `EPERM` for `getrandom`) - #60487 (Fix search sidebar width when no crate select is present) - #60511 (Fix intra-doc link resolution failure on re-exporting libstd) - #60823 (Fix incremental compilation of cdylib emitting spurious unused_attributes lint) - #60915 (stable hashing: Remove unused field and add documentation.) - #60942 (Misc changes to rustc_metadata) - #60952 (Document BinaryHeap time complexity) - #60959 (rustc: Improve type size assertions) - #60972 (remove confusing remarks about mixed volatile and non-volatile accesses) - #60983 (Set -funwind-tables and -fno-exceptions unconditionally for LLVM's libunwind) Failed merges: r? @ghost
Fixes #60381.
The second commit is a big cleanup of the media queries.
r? @rust-lang/rustdoc
cc @Manishearth
screenshot of the fix: