Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intra-doc link resolution failure on re-exporting libstd #60511

Merged
merged 1 commit into from
May 21, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented May 3, 2019

Currently, re-exporting libstd items as below will occur a lot of failures.

pub use std::*;

Until the underlying issue (#56922) fixed, we can fix that so they don't propagate to downstream crates.

Related: #56941 (That PR fixed failures that occur when re-exporting from libcore to libstd.)

r? @QuietMisdreavus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:33dc25ee:start=1556896305362585116,finish=1556896307644533201,duration=2281948085
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:27:27] 
[01:27:27] running 9 tests
[01:27:27] iiiiiiiii
[01:27:27] 
[01:27:27]  finished in 0.151
[01:27:27] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:27:43] 
[01:27:43] running 121 tests
[01:28:09] .iiiii...i.....i..i...i..i.i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i. 100/121
[01:28:13] i.i......iii.i.....ii
[01:28:13] 
[01:28:13]  finished in 30.610
[01:28:13] travis_fold:end:test_debuginfo

---
[01:50:22] travis_fold:end:stage0-linkchecker

[01:50:22] travis_time:end:stage0-linkchecker:start=1556902938686259992,finish=1556902940807284614,duration=2121024622

[01:50:25] std/boxed/struct.Box.html:362: broken link - std/boxed/trait.Error.html
[01:50:25] std/boxed/struct.Box.html:362: broken link - std/boxed/trait.Error.html
[01:50:25] std/boxed/struct.Box.html:388: broken link - std/boxed/trait.Error.html
[01:50:25] std/boxed/struct.Box.html:388: broken link - std/boxed/trait.Error.html
[01:50:25] std/boxed/struct.Box.html:420: broken link - std/boxed/trait.Error.html
[01:50:25] std/boxed/struct.Box.html:430: broken link - std/boxed/trait.Error.html
[01:50:25] std/boxed/struct.Box.html:439: broken link - std/boxed/trait.Error.html
[01:50:25] std/boxed/struct.Box.html:449: broken link - std/boxed/trait.Error.html
[01:50:25] std/boxed/struct.Box.html:458: broken link - std/boxed/trait.Error.html
[01:50:25] std/boxed/struct.Box.html:469: broken link - std/boxed/trait.Error.html
[01:50:27] std/default/trait.Default.html:100: broken link - std/default/struct.DefaultHasher.html
[01:50:27] std/borrow/enum.Cow.html:184: broken link - std/borrow/trait.Error.html
[01:50:27] std/borrow/enum.Cow.html:195: broken link - std/borrow/trait.Error.html
[01:50:27] std/convert/trait.From.html:390: broken link - std/convert/struct.SocketAddrV4.html
[01:50:27] std/convert/trait.From.html:390: broken link - std/convert/enum.SocketAddr.html
[01:50:27] std/convert/trait.From.html:391: broken link - std/convert/struct.SocketAddrV6.html
[01:50:27] std/convert/trait.From.html:391: broken link - std/convert/enum.SocketAddr.html
[01:50:27] std/convert/trait.From.html:468: broken link - std/convert/trait.Error.html
[01:50:27] std/convert/trait.From.html:478: broken link - std/convert/trait.Error.html
[01:50:27] std/convert/trait.From.html:487: broken link - std/convert/struct.OsString.html
[01:50:27] std/convert/trait.From.html:509: broken link - std/convert/trait.Error.html
[01:50:27] std/convert/trait.From.html:530: broken link - std/convert/trait.Error.html
[01:50:27] std/convert/trait.From.html:540: broken link - std/convert/trait.Error.html
[01:50:27] std/convert/trait.From.html:550: broken link - std/convert/trait.Error.html
[01:50:27] std/convert/trait.From.html:561: broken link - std/convert/trait.Error.html
[01:50:27] std/convert/trait.From.html:561: broken link - std/convert/trait.Error.html
[01:50:27] std/convert/trait.From.html:587: broken link - std/convert/trait.Error.html
[01:50:27] std/convert/trait.From.html:587: broken link - std/convert/trait.Error.html
[01:50:27] std/convert/trait.From.html:619: broken link - std/convert/enum.IpAddr.html
[01:50:27] std/convert/trait.From.html:619: broken link - std/convert/enum.SocketAddr.html
[01:50:27] std/convert/trait.From.html:620: broken link - std/convert/enum.SocketAddr.html
[01:50:27] std/convert/trait.From.html:620: broken link - std/convert/enum.IpAddr.html
[01:50:27] std/convert/trait.From.html:621: broken link - std/convert/enum.SocketAddr.html
[01:50:27] std/convert/trait.From.html:621: broken link - std/convert/enum.IpAddr.html
[01:50:27] std/convert/trait.From.html:622: broken link - std/convert/enum.SocketAddr.html
[01:50:27] std/convert/trait.From.html:635: broken link - std/convert/struct.Mutex.html
[01:50:27] std/convert/trait.From.html:637: broken link - std/convert/struct.RwLock.html
[01:50:30] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:41:9
[01:50:30] 
[01:50:30] 
[01:50:30] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:50:30] expected success, got: exit code: 101
[01:50:30] expected success, got: exit code: 101
[01:50:30] 
[01:50:30] 
[01:50:30] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:50:30] Build completed unsuccessfully in 0:34:45
[01:50:30] make: *** [check] Error 1
[01:50:30] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:07b66e08
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri May  3 17:02:29 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@taiki-e taiki-e force-pushed the libstd-intra-doc branch 2 times, most recently from 9759bc0 to c1a91f2 Compare May 3, 2019 17:28
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2c2993af:start=1556904600153122637,finish=1556904602746586546,duration=2593463909
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:18:49] 
[01:18:49] running 9 tests
[01:18:49] iiiiiiiii
[01:18:49] 
[01:18:49]  finished in 0.152
[01:18:49] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:19:05] 
[01:19:05] running 121 tests
[01:19:30] .iiiii...i.....i..i...i..i.i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i. 100/121
[01:19:35] i.i......iii.i.....ii
[01:19:35] 
[01:19:35]  finished in 30.379
[01:19:35] travis_fold:end:test_debuginfo

---
[01:42:06] travis_fold:end:stage0-linkchecker

[01:42:06] travis_time:end:stage0-linkchecker:start=1556910736254725633,finish=1556910738403086413,duration=2148360780

[01:42:10] std/default/trait.Default.html:100: broken link - collections/hash_map/struct.DefaultHasher.html
[01:42:14] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:41:9
[01:42:14] 
[01:42:14] 
[01:42:14] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:42:14] expected success, got: exit code: 101
[01:42:14] expected success, got: exit code: 101
[01:42:14] 
[01:42:14] 
[01:42:14] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:42:14] Build completed unsuccessfully in 0:35:04
[01:42:14] Makefile:48: recipe for target 'check' failed
[01:42:14] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0772cab2
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri May  3 19:12:27 UTC 2019
---
travis_time:end:2e25702d:start=1556910749050609395,finish=1556910749057102353,duration=6492958
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:08776908
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:02268ac0
travis_time:start:02268ac0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:08ec0d1a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:14e7e8c1:start=1556934960143166653,finish=1556935048138362582,duration=87995195929
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:23:46] 
[01:23:46] running 9 tests
[01:23:46] iiiiiiiii
[01:23:46] 
[01:23:46]  finished in 0.178
[01:23:46] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:24:03] 
[01:24:03] running 121 tests
[01:24:30] .iiiii...i.....i..i...i..i.i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i. 100/121
[01:24:34] i.i......iii.i.....ii
[01:24:34] 
[01:24:34]  finished in 31.284
[01:24:34] travis_fold:end:test_debuginfo

---
[01:47:05] travis_fold:end:stage0-linkchecker

[01:47:05] travis_time:end:stage0-linkchecker:start=1556941480650586094,finish=1556941482587325810,duration=1936739716

[01:47:09] std/collections/hash_map/struct.DefaultHasher.html:25: broken link - std/std/collections/hash_map/struct.DefaultHasher.html
[01:47:13] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:41:9
[01:47:13] 
[01:47:13] 
[01:47:13] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:47:13] expected success, got: exit code: 101
[01:47:13] expected success, got: exit code: 101
[01:47:13] 
[01:47:13] 
[01:47:13] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:47:13] Build completed unsuccessfully in 0:36:13
[01:47:13] Makefile:48: recipe for target 'check' failed
[01:47:13] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:007b8c91
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat May  4 03:44:51 UTC 2019
---
travis_time:end:0f8ae790:start=1556941492882380613,finish=1556941492900939342,duration=18558729
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:073f54c4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0f69abde
travis_time:start:0f69abde
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:06ceda32
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Dylan-DPC-zz
Copy link

@bors: r+

@bors
Copy link
Contributor

bors commented May 20, 2019

📌 Commit ccb9dac has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2019
Centril added a commit to Centril/rust that referenced this pull request May 20, 2019
Fix intra-doc link resolution failure on re-exporting libstd

Currently, re-exporting libstd items as below will [occur a lot of failures](https://gist.github.com/taiki-e/e33e0e8631ef47f65a74a3b69f456366).
```rust
pub use std::*;
```

Until the underlying issue (rust-lang#56922) fixed, we can fix that so they don't propagate to downstream crates.

Related: rust-lang#56941 (That PR fixed failures that occur when re-exporting from libcore to libstd.)

r? @QuietMisdreavus
bors added a commit that referenced this pull request May 20, 2019
Rollup of 11 pull requests

Successful merges:

 - #60383 (Fix position source code files toggle)
 - #60453 (Fall back to `/dev/urandom` on `EPERM` for `getrandom`)
 - #60487 (Fix search sidebar width when no crate select is present)
 - #60511 (Fix intra-doc link resolution failure on re-exporting libstd)
 - #60823 (Fix incremental compilation of cdylib emitting spurious unused_attributes lint)
 - #60915 (stable hashing: Remove unused field and add documentation.)
 - #60942 (Misc changes to rustc_metadata)
 - #60952 (Document BinaryHeap time complexity)
 - #60959 (rustc: Improve type size assertions)
 - #60972 (remove confusing remarks about mixed volatile and non-volatile accesses)
 - #60983 (Set -funwind-tables and -fno-exceptions unconditionally for LLVM's libunwind)

Failed merges:

r? @ghost
@bors bors merged commit ccb9dac into rust-lang:master May 21, 2019
@taiki-e taiki-e deleted the libstd-intra-doc branch May 21, 2019 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants