Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
Manishearth
reviewed
Oct 6, 2018
Member
There was a problem hiding this comment.
Can this documentation be moved into the reference somewhere?
Member
Author
There was a problem hiding this comment.
I think the best spot for this would be here:
https://github.com/rust-lang-nursery/reference/blob/master/src/attributes.md#lint-check-attributes
Manishearth
approved these changes
Oct 6, 2018
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
r=me, but let's preserve the documentation somehow
Centril
added
the
relnotes
Collaborator
|
☔ The latest upstream changes (presumably #54835) made this pull request unmergeable. Please resolve the merge conflicts. |
Manishearth
force-pushed
the
stabilize_tool_lints
branch
from
6fb4ff6 to
ffe1527
Compare
Member
|
@bors r+ rebased I'll make a PR to the reference. |
Collaborator
|
📌 Commit ffe1527 has been approved by |
bors
added
S-waiting-on-bors
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Oct 10, 2018
…nishearth Stabilize tool lints cc rust-lang#44690 This stabilizes the `tool_lints` feature. This is my first stabilization PR, let me know if I missed something. I followed the guide on https://forge.rust-lang.org. Should the documentation of the `tool_lints` be moved to `rust-lang-nursery/reference`? r? @Manishearth @nrc
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 10, 2018
…nishearth Fixes rust-lang#47311. r? @nrc
bors
added a commit
that referenced
this pull request
Oct 11, 2018
Rollup of 9 pull requests Successful merges: - #54747 (codegen_llvm: verify that inline assembly operands are scalars) - #54848 (Better Diagnostic for Trait Object Capture) - #54850 (Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls) - #54858 (second round of refactorings for universes) - #54862 (Implement RFC 2539: cfg_attr with multiple attributes) - #54869 (Fix mobile docs) - #54870 (Stabilize tool lints) - #54893 (Fix internal compiler error on malformed match arm pattern.) - #54904 (Stabilize the `Option::replace` method) Failed merges: - #54909 ( Add chalk rules related to associated type defs) r? @ghost
bors
added a commit
that referenced
this pull request
Oct 11, 2018
Rollup of 9 pull requests Successful merges: - #54747 (codegen_llvm: verify that inline assembly operands are scalars) - #54848 (Better Diagnostic for Trait Object Capture) - #54850 (Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls) - #54858 (second round of refactorings for universes) - #54862 (Implement RFC 2539: cfg_attr with multiple attributes) - #54869 (Fix mobile docs) - #54870 (Stabilize tool lints) - #54893 (Fix internal compiler error on malformed match arm pattern.) - #54904 (Stabilize the `Option::replace` method) Failed merges: - #54909 ( Add chalk rules related to associated type defs) r? @ghost
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #44690
This stabilizes the
tool_lintsfeature.This is my first stabilization PR, let me know if I missed something. I followed the guide on https://forge.rust-lang.org. Should the documentation of the
tool_lintsbe moved torust-lang-nursery/reference?r? @Manishearth @nrc