Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize min_const_fn #54835

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Oct 5, 2018

tracking issue: #53555

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2018
@rust-highfive

This comment has been minimized.

@oli-obk oli-obk force-pushed the mögen_konstante_funktionen_doch_bitte_endlich_stabil_sein branch from cfc51f0 to ec74d35 Compare October 5, 2018 08:36
@rust-highfive

This comment has been minimized.

@killercup
Copy link
Member

You constantly surprise me, Oli: TIL git(hub) apparently works well with unicode branch names.

@Centril
Copy link
Contributor

Centril commented Oct 5, 2018

Extra points for a great branch name =P

/me considers branch names in Swedish now

@Centril Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 5, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Oct 5, 2018

r? @RalfJung

The tracking issue has been FCPed and accepted for merging. @Centril already signed off.

@rust-highfive rust-highfive assigned RalfJung and unassigned Centril Oct 5, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Oct 5, 2018

Oh wait

@bors r=Centril

😈

@bors
Copy link
Contributor

bors commented Oct 5, 2018

📌 Commit fb04e26 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2018
@bors
Copy link
Contributor

bors commented Oct 7, 2018

⌛ Testing commit fb04e26 with merge 0ee045e...

bors added a commit that referenced this pull request Oct 7, 2018
…endlich_stabil_sein, r=Centril

Stabilize `min_const_fn`

tracking issue: #53555

r? @Centril
@Centril
Copy link
Contributor

Centril commented Oct 7, 2018

🙏

@bors
Copy link
Contributor

bors commented Oct 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Centril
Pushing 0ee045e to master...

rubdos added a commit to rubdos/curve25519-dalek that referenced this pull request May 28, 2020
const_fn is stable since Rust 1.31
(rust-lang/rust#54835) and enables calling
`Scalar::from_bits(..)` from other const fn contexts, potentially
saving some overhead here and there.

Especially useful in contexts where constants are being built from a bit
pattern.
@oli-obk oli-obk deleted the mögen_konstante_funktionen_doch_bitte_endlich_stabil_sein branch May 31, 2020 13:17
plotskogwq added a commit to plotskogwq/curve25519-dalek that referenced this pull request Aug 10, 2024
const_fn is stable since Rust 1.31
(rust-lang/rust#54835) and enables calling
`Scalar::from_bits(..)` from other const fn contexts, potentially
saving some overhead here and there.

Especially useful in contexts where constants are being built from a bit
pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants