Updated Release notes for 1.22.0 #45454

XAMPPRocky · 2017-10-22T19:16:32Z

rust-highfive · 2017-10-22T19:16:43Z

(rust_highfive has picked a reviewer for you, use r? to override)

bluss · 2017-10-22T19:19:35Z

RELEASES.md

+  on `armv5te_unknown_linux_gnueabi`][44978]
+- [`Box<Error>` now impls `Cow<str>`][44466]
+- [`std::mem::Discriminant` is now guarenteed to be `Send + Sync` if `T`
+  is `Send + Sync`][45095]


Discriminant<T> is now Send/Sync regardless of T. It's a bug fix, before it was never Send/Sync.

est31 · 2017-10-22T20:24:34Z

RELEASES.md

+- [`non_snake_case` lint now allows extern no-mangle functions][44966]
+- [Now accepts underscores in unicode escapes][43716]
+- [`#![feature(const_fn)]` is now no longer required for using
+  const functions][43017] Still required for creating constant functions.


Maybe add a period and "It's"?

est31 · 2017-10-22T20:30:14Z

RELEASES.md

+
+Compiler
+--------
+- [rustc now defaults to having 32 codegen units at debug][44853]


It got reduced to 16 in fact. On master, its also disabled on some targets, but the second PR didn't make it into beta.

est31 · 2017-10-22T20:35:02Z

RELEASES.md

+- [Cargo will now build multi file examples in subdirectories of the `examples`
+  folder that have a `main.rs` file.][cargo/4496]
+- [Changed `[root]` to `[package]` in `Cargo.lock`][cargo/4571] Packages with
+  the old format will continue to work and can be updated with `cargo update`.


Don't forget rust-lang/cargo#3992 which is IMO the most important addition to cargo in the current release.

(the entry has been added since but github doesn't show that)

frewsxcv

nice work!👌

frewsxcv · 2017-10-22T23:05:45Z

RELEASES.md

+--------
+- [`non_snake_case` lint now allows extern no-mangle functions][44966]
+- [Now accepts underscores in unicode escapes][43716]
+- [`#![feature(const_fn)]` is now no longer required for using


'calling const functions' instead of 'using const functions' might be clearer here

kennytm · 2017-10-23T09:23:44Z

RELEASES.md

+- [`non_snake_case` lint now allows extern no-mangle functions][44966]
+- [Now accepts underscores in unicode escapes][43716]
+- [`#![feature(const_fn)]` is now no longer required for
+  calling const functions.][43017] It's Still required for creating


lower case "still"

kennytm · 2017-10-23T09:24:04Z

RELEASES.md

+
+Compiler
+--------
+- [rustc now defaults to having 16 codegen units at debug on supported platforms.][44853]


The link to 44853 is missing.

kennytm · 2017-10-23T09:43:41Z

Unfortunately due to robot misbehavior, the PRs involved in #44936 are not marked as "merged" on GitHub. In particular this includes #44287, which stabilized T += &T for numeric types, that I think should be included in the release note.

There is also #44456, which stabilized drop_types_in_const (rust-lang/rfcs#1817), marked as "since 1.22.0" in the source code.

alexcrichton · 2017-10-23T16:01:20Z

Thanks so much for doing this again @Aaronepower!

cuviper · 2017-10-23T22:50:01Z

RELEASES.md

+Libraries
+---------
+- [Allow atomic operations up to 32 bits
+  on `armv5te_unknown_linux_gnueabi`][44978]


GitHub isn't rendering this link -- perhaps it can't be multiline?

I can't replicate this. It's a working link for me. Are you getting still getting this?

Looks fine now. 🤷‍♂️

cuviper · 2017-10-23T22:50:18Z

RELEASES.md

+- [Allow atomic operations up to 32 bits
+  on `armv5te_unknown_linux_gnueabi`][44978]
+- [`Box<Error>` now impls `Cow<str>`][44466]
+- [`std::mem::Discriminant` is now guarenteed to be `Send + Sync`][45095]


*guaranteed

cuviper · 2017-10-23T22:51:55Z

RELEASES.md

+---------
+- [Allow atomic operations up to 32 bits
+  on `armv5te_unknown_linux_gnueabi`][44978]
+- [`Box<Error>` now impls `Cow<str>`][44466]


A type doesn't implement another type -- it now implements From<Cow<str>>

bluss · 2017-10-28T14:35:08Z

RELEASES.md

+- [Now accepts underscores in unicode escapes][43716]
+- [`#![feature(const_fn)]` is now no longer required for
+  calling const functions.][43017] It's still required for creating
+  constant functions.


Individual const functions are still unstable one by one — is there any of them that are stable in Rust 1.22?

I think mem::size_of?

That would be amazing, but const size_of is not stabilized in current nighly.

cc @durka Do you know any?

There are none so far. We only put the infrastructure in place for doing them individually. I thought size_of was imminent though, what happened?

@Aaronepower Can we remove this line about const functions? Since it has no user-visible effect in Rust 1.22

@bluss Well shouldn't it still be included since this is when it was stabilised?

What's misleading about the current bullet point is you still need a feature gate for calling const fns, just a different one (in fact a different one per fn now). So you can't do anything on stable that you couldn't before.

I agree with durka here, it's nothing user-visible (unfortunately) for the Rust 1.22.0 release.

bluss · 2017-10-28T16:11:55Z

I think this is new in beta: Option<T> implements the Try trait, and it's stable to use with the ? operator in beta. #42526

XAMPPRocky · 2017-10-28T18:57:23Z

@bluss Do you know where the PR that stabilised it is?

bluss · 2017-10-28T18:59:11Z

it's a trait impl, so it's the one

XAMPPRocky · 2017-10-28T19:17:22Z

@bluss Why do the tests have a feature attribute for use then? https://github.com/rust-lang/rust/pull/42526/files#diff-6febfa0310e72467e28d435a668df56fR11

bluss · 2017-10-28T19:22:53Z

Short-circuiting with ? on option is stable in beta: https://play.rust-lang.org/?gist=8314fe5d499d96198d02726c95180fe0&version=beta

I don't know, that link shows interaction like Option to Result conversion, maybe it's that?

kennytm · 2017-10-28T19:23:41Z

@Aaronepower That's for the std::option::NoneError type which is gated behind the try_trait feature.

kennytm · 2017-10-31T14:21:43Z

@Aaronepower When #45656 is merged, please add a compatibility note that Android 2.3- is no longer supported, the minimum would be Android 4.0+. Thanks!

kennytm · 2017-11-04T16:00:10Z

RELEASES.md

+
+Misc
+----
+- [`libbacktrace` is now available on Apple platforms.][44251]


~~@Aaronepower Please delete this line after #45760 is backported to beta. This feature is being reverted because it is found to be causing segfault (#45731).~~

Never mind, a fix without reverting was found.

kennytm · 2017-11-13T19:10:01Z

@Aaronepower Just wanna note that #44287 (mentioned in #45454 (comment)) is still not listed in the release note. This needs a compatibility warning as this will break inference involving x += y.

cc #45480.

shepmaster · 2017-11-18T17:48:41Z

Ping from triage @alexcrichton — care to gaze deeply into the notes of future release?

alexcrichton · 2017-11-19T16:12:12Z

Ok thanks @Aaronepower! I'm gona merge this as the release is now upcoming

@bors: r+

bors · 2017-11-19T16:12:12Z

📌 Commit e0ac864 has been approved by alexcrichton

bors · 2017-11-19T17:23:08Z

⌛ Testing commit e0ac864 with merge 5041b3b...

Updated Release notes for 1.22.0 [rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

bors · 2017-11-19T19:55:12Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5041b3b to master...

Updated Release notes for 1.22.0

332759d

rust-highfive assigned alexcrichton Oct 22, 2017

bluss reviewed Oct 22, 2017

View reviewed changes

Update RELEASES.md

4fbf56c

est31 reviewed Oct 22, 2017

View reviewed changes

frewsxcv reviewed Oct 22, 2017

View reviewed changes

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2017

Update RELEASES.md

045032a

kennytm reviewed Oct 23, 2017

View reviewed changes

cuviper reviewed Oct 23, 2017

View reviewed changes

Update RELEASES.md

7e25527

bluss reviewed Oct 28, 2017

View reviewed changes

alexcrichton mentioned this pull request Oct 30, 2017

Add unit test checking to cargo check rust-lang/cargo#4592

Merged

Aaronepower added 2 commits November 1, 2017 10:18

Update RELEASES.md

5a9d833

Update RELEASES.md

b93c95a

kennytm reviewed Nov 4, 2017

View reviewed changes

Update RELEASES.md

e0ac864

kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2017

bors added a commit that referenced this pull request Nov 19, 2017

Auto merge of #45454 - Aaronepower:master, r=alexcrichton

5041b3b

Updated Release notes for 1.22.0 [rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

bors merged commit e0ac864 into rust-lang:master Nov 19, 2017

Updated Release notes for 1.22.0 #45454

Updated Release notes for 1.22.0 #45454

Conversation

XAMPPRocky commented Oct 22, 2017

rust-highfive commented Oct 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frewsxcv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kennytm commented Oct 23, 2017

alexcrichton commented Oct 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bluss Oct 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bluss commented Oct 28, 2017 • edited Loading

XAMPPRocky commented Oct 28, 2017

bluss commented Oct 28, 2017

XAMPPRocky commented Oct 28, 2017

bluss commented Oct 28, 2017

kennytm commented Oct 28, 2017

kennytm commented Oct 31, 2017

kennytm Nov 4, 2017 • edited Loading

Choose a reason for hiding this comment

kennytm commented Nov 13, 2017 • edited Loading

shepmaster commented Nov 18, 2017

alexcrichton commented Nov 19, 2017

bors commented Nov 19, 2017

bors commented Nov 19, 2017

bors commented Nov 19, 2017

bluss Oct 28, 2017 •

edited

Loading

bluss commented Oct 28, 2017 •

edited

Loading

kennytm Nov 4, 2017 •

edited

Loading

kennytm commented Nov 13, 2017 •

edited

Loading