Updated RELEASES.md for 1.21.0 by XAMPPRocky · Pull Request #44481 · rust-lang/rust

XAMPPRocky · 2017-09-10T22:26:00Z

rust-highfive · 2017-09-10T22:26:14Z

(rust_highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2017-09-10T22:45:28Z

RELEASES.md

+
+Libraries
+---------
+- [Generate builtin impls for `Clone` for `[T: N]` where `N` is between 0


typo [T; N]

petrochenkov · 2017-09-10T22:50:37Z

RELEASES.md

+Language
+--------
+- [Relaxed path syntax. You can now add type parameters to values][43540]
+  Example: `struct Foo<T>(T); let bar = Foo::<u8>(0);`.


Foo::<u8>(0) was always possible, what #43540 does is permitting (sometimes unnecessary) :: before < in all paths, including paths passed to macros.
Previously:

my_macro!(Vec<i32>::new); // OK my_macro!(Vec::<i32>::new); // ERROR

Now:

my_macro!(Vec<i32>::new); // OK my_macro!(Vec::<i32>::new); // OK too

zackmdavis · 2017-09-11T01:26:08Z

RELEASES.md

+- [Remove the trait selection impl in method::probe][43880] This may cause
+  breakage in subtyping corner cases.
+- [make JSON error's byte position start at top of file.][42973] Was previously
+  relative to the `CodeMap` which required unstable code.


Release note readers shouldn't need to think about named internal implementation details like CodeMap, and I'm not sure where "which required unstable code" is coming from.

Maybe something like "was previously relative to a concatenation of files in a crate"?? (I don't actually know how the compiler determines which files go in a CodeMap—and neither does typical consumer of error-message JSON, which is why we fixed this).

zackmdavis · 2017-09-11T01:28:31Z

There should also be a compatibility bullet point for the unused_results lint getting stronger. "unused_results lint no longer ignores booleans"?

kennytm · 2017-09-11T09:59:30Z

RELEASES.md

+Compatibility Notes
+-------------------
+- [Remove the trait selection impl in method::probe][43880] This may cause
+  breakage in subtyping corner cases.


Is there any breakage examples?

BTW "trait selection impl in method::probe" sounds too technical for readers.

It definitely is I just couldn't think of anything better. @arielb1 would you know a better explanation and example?

@Aaronepower: Maybe summarize or just link to #44224 (comment) ?

XAMPPRocky · 2017-09-11T14:00:00Z

@zackmdavis Could you provide a PR link? I can't seem to find the PR that makes the lint stronger.

alexcrichton

Thanks @Aaronepower!

I think this may also want to mention [patch] in Cargo (detailed in RFC 1969)

alexcrichton · 2017-09-11T14:30:15Z

RELEASES.md

+Misc
+----
+- [Cargo docs are moving][43916]
+  to [doc.rust-lang.org/cargo](https://doc.rust-lang.org/cargo)


We may not want to highlight this just yet as they're still a redirect to doc.crates.io, but soon though!

I didn't think so either, it was marked as relnotes so I included it.

alexcrichton · 2017-09-11T14:34:12Z

Another Cargo change that may be worth mentioning is rust-lang/cargo#4270, a change to the ignore/exclude syntax

alexcrichton · 2017-09-11T14:36:00Z

Also rust-lang/cargo#4400, the addition of the --all-targets flag

alexcrichton · 2017-09-11T14:36:23Z

Also rust-lang/cargo#4364, a new compatibility note

alexcrichton · 2017-09-11T14:37:43Z

Speaking of lint changes, I believe unused_extern_crate was turned on by default in #42588

zackmdavis · 2017-09-11T18:43:30Z

@Aaronepower

Could you provide a PR link? I can't seem to find the PR that makes the lint stronger.

The change was, somewhat embarrassingly, unintentional in #43728 (removed a TyBool => return match arm without realizing that this would let us "fall through" to the part of the lint-pass that sets unused_results), but then the discussion and final-comment-period in #44119 retroactively ruled it a bugfix rather than a regression.

ollie27

Looks like #43838 is missing.

ollie27 · 2017-09-11T21:49:24Z

RELEASES.md

+Libraries
+---------
+- [Generate builtin impls for `Clone` for `[T; N]` where `N` is between 0
+  and 32][43690]


It's more than this. Clone is now implemented for all arrays with T: Clone, all tuples with every member being Clone and all function pointers.

ollie27 · 2017-09-11T21:52:28Z

RELEASES.md

+  like patterns][cargo/4270]
+- [Added the `--all-targets` option][cargo/4400]
+- [Using required dependencies as a feature is now deprecated and emits
+  a warning][cargo/]


missing link

alexcrichton · 2017-09-19T15:14:53Z

gah sorry for letting this sit @Aaronepower! slipped off my radar :(

In any case looks great, thanks so much again for tackling this! Let's get this in and we can continue to iterate in-tree

@bors: r+

bors · 2017-09-19T15:14:55Z

📌 Commit f3c316d has been approved by alexcrichton

bors · 2017-09-20T14:45:43Z

⌛ Testing commit f3c316d with merge 547d8a36ef4903810e779313cd0f9ffd3522b92b...

bors · 2017-09-20T14:50:27Z

💔 Test failed - status-appveyor

kennytm · 2017-09-20T15:38:05Z

@bors retry Wat.

Spurious network error, can't resolve crates.io.

bors · 2017-09-20T17:44:05Z

⌛ Testing commit f3c316d with merge 65e8d5afd9f7d4eaaeed2db28b9b4555377aa420...

nrc · 2017-09-20T20:10:36Z

Adds the RLS! rustup component add rls-preview

XAMPPRocky · 2017-09-20T20:30:02Z

@nrc I've added that, let know if the PR I picked is the wrong one to link.

kennytm · 2017-09-21T14:42:44Z

RELEASES.md

+  Example:
+  ```rust
+  fn main() {
+      let x: &'static u32 = 0;


This should be &0, not 0.

dtolnay · 2017-09-21T16:52:32Z

We are stabilizing std::mem::discriminant in 1.21. #44263, #44552

We could backport any of the following library stabilizations -- I'm not clear how we decide whether to do that.

TcpStream::connect_timeout stabilize tcpstream_connect_timeout (closes #43079) #44563
Iterator::for_each stabilized iterator_for_each (closes #42986) #44567
Ord::min/max stabilized ord_max_min (fixes #25663) #44593
std::sync::atomic::compiler_fence stabilized compiler_fences (fixes #41091) #44595
std::mem::needs_drop stabilized needs_drop (fixes #41890) #44639
Vec::splice Stabilized vec_splice and modified splice tracking issue #44640

QuietMisdreavus · 2017-09-21T16:53:20Z

The docs got a few notable quality-of-life additions. Not sure whether they're all "release notes" worthy, but i'll note them here all the same:

std::os docs for Unix, Linux, and Windows now appear in all docs, including the ones online
references and function pointers have their own primitive pages in the std docs
trait implementors now print their associated types without having to go to the type's page to find them

michaelwoerister · 2017-09-23T18:22:46Z

I think the "async-llvm" changes from #43506 will be in the next release (right, @alexcrichton?). This feature is pretty neat and it solves a fundamental problem we started running into with incremental compilation: Before, the amount of memory consumed by the LLVM part of compilation was determined by the total size of your crate. After, it is determined by the size of the largest N codegen-units, where N is the number of parallel threads you tell rustc to use. Note that this is something especially important for incr. comp. but the feature helps with any setup that uses codegen-units=N.

Together with @alexcrichton's jobserver changes, this makes using something like codegen-units= 2 * cpu-core-count much more viable, if runtime performance is not the highest priority (e.g. most kinds of development builds).

arielb1 · 2017-09-26T18:11:51Z

RELEASES.md

+--------
+- [Upgraded jemalloc to 4.5.0][43911]
+- [Enabled unwinding panics on Redox][43917]
+- [Now emits a warning when you have an unused `extern crate`][42588]


This is being backed out (#44825)

alexcrichton · 2017-10-05T00:02:02Z

Alright the release is just around the corner, so let's merge!

@bors: r+

bors · 2017-10-05T00:02:04Z

📌 Commit 7ed23f1 has been approved by alexcrichton

bors · 2017-10-05T02:53:50Z

⌛ Testing commit 7ed23f1 with merge bd36dcf...

Updated RELEASES.md for 1.21.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

bors · 2017-10-05T05:16:37Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing bd36dcf to master...

Updated RELEASES.md for 1.21.0

afa007c

rust-highfive assigned alexcrichton Sep 10, 2017

petrochenkov reviewed Sep 10, 2017

View reviewed changes

zackmdavis reviewed Sep 11, 2017

View reviewed changes

kennytm reviewed Sep 11, 2017

View reviewed changes

Update RELEASES.md

8b5ca08

carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2017

alexcrichton reviewed Sep 11, 2017

View reviewed changes

Update RELEASES.md

3c6a800

ollie27 reviewed Sep 11, 2017

View reviewed changes

alexcrichton added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2017

Aaronepower added 2 commits September 18, 2017 19:08

Update RELEASES.md

045b4f1

Update RELEASES.md

f3c316d

arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 19, 2017

Aaronepower added 2 commits September 20, 2017 21:28

Update RELEASES.md

8f424f2

Update RELEASES.md

e68c20e

kennytm requested changes Sep 21, 2017

View reviewed changes

RELEASES.md Outdated

Example:

```rust

fn main() {

let x: &'static u32 = 0;

Copy link

Member

kennytm Sep 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be &0, not 0.

alexcrichton added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 21, 2017

arielb1 reviewed Sep 26, 2017

View reviewed changes

Update RELEASES.md

7ed23f1

bors added a commit that referenced this pull request Oct 5, 2017

Auto merge of #44481 - Aaronepower:master, r=alexcrichton

bd36dcf

Updated RELEASES.md for 1.21.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

bors merged commit 7ed23f1 into rust-lang:master Oct 5, 2017

Uh oh!

Conversation

XAMPPRocky commented Sep 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Sep 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zackmdavis commented Sep 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XAMPPRocky commented Sep 11, 2017

Uh oh!

alexcrichton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XAMPPRocky Sep 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Sep 11, 2017

Uh oh!

alexcrichton commented Sep 11, 2017

Uh oh!

alexcrichton commented Sep 11, 2017

Uh oh!

alexcrichton commented Sep 11, 2017

Uh oh!

zackmdavis commented Sep 11, 2017

Uh oh!

ollie27 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Sep 19, 2017

Uh oh!

bors commented Sep 19, 2017

Uh oh!

bors commented Sep 20, 2017

Uh oh!

bors commented Sep 20, 2017

Uh oh!

kennytm commented Sep 20, 2017

Uh oh!

bors commented Sep 20, 2017

Uh oh!

nrc commented Sep 20, 2017

Uh oh!

XAMPPRocky commented Sep 20, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Sep 21, 2017

Uh oh!

QuietMisdreavus commented Sep 21, 2017

Uh oh!

michaelwoerister commented Sep 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Oct 5, 2017

Uh oh!

bors commented Oct 5, 2017

Uh oh!

bors commented Oct 5, 2017

XAMPPRocky commented Sep 10, 2017 •

edited

Loading

XAMPPRocky Sep 11, 2017 •

edited

Loading