-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stabilized compiler_fences (fixes #41091) #44595
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks! Maybe the docs could move to the function? |
I've translated part of the unstable-book article into an example. I'm not sure if it didn't came out forced. |
📌 Commit 571941b has been approved by |
Hmm, I think I would argue for more of the text from the unstable book to be incorporated into the documentation for |
@alexcrichton Gladly! Although I might not have time to approach it this weekend.
@jonhoo I've originally omitted these paragraphs as these convey the same message as current docs present above
I'm not sure about linking to C++ reference but I would prefer not to point to StackOverflow, leaving only the linux kernel link. |
571941b
to
5f62c0c
Compare
I've updated the docs with the best I could come up with :) |
@bors: r+ |
📌 Commit 5f62c0c has been approved by |
LGTM 👍 |
…=alexcrichton stabilized compiler_fences (fixes rust-lang#41091) I did not know what to proceed with "unstable-book" entry. The feature would no longer be unstable so I have deleted it. If it was the wrong call I'll revert it (unfortunately his case is not described in the CONTRIBUTING.md).
…=alexcrichton stabilized compiler_fences (fixes rust-lang#41091) I did not know what to proceed with "unstable-book" entry. The feature would no longer be unstable so I have deleted it. If it was the wrong call I'll revert it (unfortunately his case is not described in the CONTRIBUTING.md).
…=alexcrichton stabilized compiler_fences (fixes rust-lang#41091) I did not know what to proceed with "unstable-book" entry. The feature would no longer be unstable so I have deleted it. If it was the wrong call I'll revert it (unfortunately his case is not described in the CONTRIBUTING.md).
The way it is currently written, the `assert_eq!` is *not* guaranteed to | ||
succeed, despite everything happening in a single thread. To see why, | ||
remember that the compiler is free to swap the stores to | ||
`IMPORTANT_VARIABLE` and `IS_READ` since they are both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a typo? IS_READY instead of IS_READ (perhaps occurs several times)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should be IS_READY
This includes the following stabilizations: - tcpstream_connect_timeout rust-lang#44563 - iterator_for_each rust-lang#44567 - ord_max_min rust-lang#44593 - compiler_fences rust-lang#44595 - needs_drop rust-lang#44639 - vec_splice rust-lang#44640
This includes the following stabilizations: - tcpstream_connect_timeout rust-lang#44563 - iterator_for_each rust-lang#44567 - ord_max_min rust-lang#44593 - compiler_fences rust-lang#44595 - needs_drop rust-lang#44639 - vec_splice rust-lang#44640
[beta] Backport accepted PRs to 1.21 Backport of: - ~don't suggest placing `use` statements into expanded code #44215 - stabilize tcpstream_connect_timeout #44563 - stabilized iterator_for_each #44567 - travis: Move sccache to the us-west-1 region #44574 - stabilized ord_max_min #44593 - stabilized compiler_fences #44595 - ci: Upload/download from a new S3 bucket #44617 - stabilized needs_drop #44639 - Stabilized vec_splice and modified splice tracking issue #44640 - Backport libs stabilizations to 1.21 beta #44824
Backport libs stabilizations to 1.21 beta Includes the following stabilizations: - tcpstream_connect_timeout rust-lang#44563 - iterator_for_each rust-lang#44567 - ord_max_min rust-lang#44593 - compiler_fences rust-lang#44595 - needs_drop rust-lang#44639 - vec_splice rust-lang#44640 These have been backported in rust-lang#44823.
I did not know what to proceed with "unstable-book" entry. The feature would no longer be unstable so I have deleted it. If it was the wrong call I'll revert it (unfortunately his case is not described in the CONTRIBUTING.md).