try to fix lvalue ops for real #41828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this is the last PR needed. Fixes rust-lang#41726. Fixes rust-lang#41742. Fixes rust-lang#41774.
|
r? @eddyb |
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 052d071 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
May 9, 2017
try to fix lvalue ops for real Hopefully this is the last PR needed. Fixes rust-lang#41726. Fixes rust-lang#41742. Fixes rust-lang#41774.
bors
added a commit
that referenced
this pull request
May 9, 2017
arielb1
added
the
beta-nominated
|
Beta-nominating because this fixes regression introduces in #41578 which is going into beta. |
Merged
nikomatsakis
added
the
beta-accepted
|
Accepting for beta. Small-ish patch, serious soundness regressions. cc @rust-lang/compiler |
nikomatsakis
added
the
T-compiler
|
Backport in #42053 |
bors
added a commit
that referenced
this pull request
May 22, 2017
Beta backport various arielb1 patches Backport of the following PRs: - #41651 - #41828 cc @arielb1 @rust-lang/compiler
brson
removed
the
beta-nominated
|
Looks like this has been backported. Removed the nominated tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this is the last PR needed.
Fixes #41726.
Fixes #41742.
Fixes #41774.