refactor the handling of lvalue ops #41651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
added
the
beta-nominated
|
@bors r+ |
|
📌 Commit b7b3c23 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
|
Please review for backport. |
nikomatsakis
added
the
beta-accepted
|
Accepting for backport. It's a large-ish patch, but it's been landed a while, and this bug is blocking Firefox. cc @rust-lang/compiler |
nikomatsakis
added
the
T-compiler
|
Backport in #42053 |
bors
added a commit
that referenced
this pull request
May 22, 2017
Beta backport various arielb1 patches Backport of the following PRs: - #41651 - #41828 cc @arielb1 @rust-lang/compiler
brson
removed
the
beta-nominated
|
This has been backported. Removed the nominated tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I got the code into a "mostly sane" situation.
Fixes #41604.
beta-nominating because fixes regression in #41578. I think I can do a smaller fix, but the previous code is too fragile.
r? @eddyb