Add test for correct span for type #38606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ rollup |
|
📌 Commit 3caf478 has been approved by |
|
⌛ Testing commit 3caf478 with merge 809de12... |
|
💔 Test failed - status-travis |
|
Hmm, @bors retry |
|
⌛ Testing commit 3caf478 with merge 5d451cd... |
|
💔 Test failed - status-travis |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 4, 2017
…nkov Add test for correct span for type Adds test for and closes rust-lang#27522.
estebank
force-pushed
the
test-for-27522
branch
from
3caf478
to
1a4a6b9
Compare
|
Had to change test as the error is pointing at the type now instead of the argument. Rebased and fixed. Can I get a new r+ for the rebase, @petrochenkov? The error difference is: |
|
@bors r+ rollup |
|
📌 Commit 1a4a6b9 has been approved by |
|
⌛ Testing commit 1a4a6b9 with merge 88c6820... |
|
💔 Test failed - status-travis |
|
@petrochenkov can I get a retry? The travis error is unrelated to this PR: |
|
@bors: retry
* network error
…On Mon, Jan 9, 2017 at 8:51 AM, Esteban Kuber ***@***.***> wrote:
@petrochenkov <https://github.com/petrochenkov> can I get a retry? The
travis error is unrelated to this PR:
Downloading num_cpus v0.2.13
warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
error: unable to get packages from source
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38606 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95LGz_zuUSB_TH0SjwolWICvj0rc_ks5rQmWugaJpZM4LVd45>
.
|
sanxiyn
added a commit
to sanxiyn/rust
that referenced
this pull request
Jan 10, 2017
…nkov Add test for correct span for type Adds test for and closes rust-lang#27522.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test for and closes #27522.