Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs for TcpListener example. #38845

Closed
wants to merge 1 commit into from
Closed

Fix docs for TcpListener example. #38845

wants to merge 1 commit into from

Conversation

ShaunKarran
Copy link

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jan 5, 2017

📌 Commit ec9adcc has been approved by GuillaumeGomez

@frewsxcv frewsxcv mentioned this pull request Jan 9, 2017
Closed
@sanxiyn sanxiyn mentioned this pull request Jan 10, 2017
Merged
bors added a commit that referenced this pull request Jan 10, 2017
@bors
Auto merge of #38958 - sanxiyn:rollup, r=sanxiyn
7bffede 
Rollup of 11 pull requests

- Successful merges: #38606, #38607, #38623, #38664, #38799, #38816, #38836, #38839, #38841, #38849, #38874
- Failed merges: #38845
@bors
Copy link
Contributor

bors commented Jan 10, 2017

☔ The latest upstream changes (presumably #38958) made this pull request unmergeable. Please resolve the merge conflicts.

@sanxiyn
Copy link
Member

sanxiyn commented Jan 11, 2017

Another person made the same change, which got merged first, see #38799. I am sorry about that.

@sanxiyn sanxiyn closed this Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ShaunKarran @rust-highfive @GuillaumeGomez @bors @sanxiyn @sfackler